Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/browser/background_fetch/background_fetch_data_manager_unittest.cc

Issue 2778793002: Start aligning BackgroundFetchRequestInfo with the passed in request object. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_data_manager_unittest.cc
diff --git a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
index 155bea3bc70f96f0bd42d3c5ddec8a62c4e20342..3e5faaacfb13d18294534b70c724cf0e45bf2557 100644
--- a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
+++ b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
@@ -46,12 +46,15 @@ class BackgroundFetchDataManagerTest : public ::testing::Test {
// Create |num_requests| BackgroundFetchRequestInfo's.
std::vector<std::unique_ptr<BackgroundFetchRequestInfo>> request_infos;
for (int i = 0; i < num_requests; i++) {
+ ServiceWorkerHeaderMap headers;
+ ServiceWorkerFetchRequest request(GURL(kResource), "GET", headers,
+ Referrer(), false /* is_reload */);
request_infos.push_back(
- base::MakeUnique<BackgroundFetchRequestInfo>(GURL(kResource), kTag));
+ base::MakeUnique<BackgroundFetchRequestInfo>(request));
}
std::unique_ptr<BackgroundFetchJobInfo> job_info =
base::MakeUnique<BackgroundFetchJobInfo>(
- "tag", url::Origin(GURL(kJobOrigin)), kServiceWorkerRegistrationId);
+ kTag, url::Origin(GURL(kJobOrigin)), kServiceWorkerRegistrationId);
job_guid_ = job_info->guid();
background_fetch_data_manager_->CreateRequest(std::move(job_info),
std::move(request_infos));
@@ -112,7 +115,6 @@ TEST_F(BackgroundFetchDataManagerTest, CompleteJob) {
const BackgroundFetchRequestInfo& request_info =
data_manager->GetNextBackgroundFetchRequestInfo(job_guid());
request_guids.push_back(request_info.guid());
- EXPECT_EQ(request_info.tag(), kTag);
EXPECT_EQ(request_info.state(),
DownloadItem::DownloadState::MAX_DOWNLOAD_STATE);
EXPECT_EQ(request_info.interrupt_reason(),

Powered by Google App Engine
This is Rietveld 408576698