Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/inspector/v8-console-message.h

Issue 2778743007: Revert of [inspector] console get all information from inspector when needed (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-console.cc ('k') | src/inspector/v8-console-message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-console-message.h
diff --git a/src/inspector/v8-console-message.h b/src/inspector/v8-console-message.h
index 3c7cc78856771a0b5707f04ef499b36a70ff78fe..8ab81f4dcbdb1772f9a1b35b26e3fb70b2dcb429 100644
--- a/src/inspector/v8-console-message.h
+++ b/src/inspector/v8-console-message.h
@@ -6,8 +6,6 @@
#define V8_INSPECTOR_V8CONSOLEMESSAGE_H_
#include <deque>
-#include <map>
-#include <set>
#include "include/v8.h"
#include "src/inspector/protocol/Console.h"
#include "src/inspector/protocol/Forward.h"
@@ -46,10 +44,9 @@
~V8ConsoleMessage();
static std::unique_ptr<V8ConsoleMessage> createForConsoleAPI(
- v8::Local<v8::Context> v8Context, int contextId, int groupId,
- V8InspectorImpl* inspector, double timestamp, ConsoleAPIType,
+ double timestamp, ConsoleAPIType,
const std::vector<v8::Local<v8::Value>>& arguments,
- std::unique_ptr<V8StackTraceImpl>);
+ std::unique_ptr<V8StackTraceImpl>, InspectedContext*);
static std::unique_ptr<V8ConsoleMessage> createForException(
double timestamp, const String16& detailedMessage, const String16& url,
@@ -115,23 +112,11 @@
void contextDestroyed(int contextId);
void clear();
- bool shouldReportDeprecationMessage(int contextId, const String16& method);
- int count(int contextId, const String16& id);
- void time(int contextId, const String16& id);
- double timeEnd(int contextId, const String16& id);
-
private:
V8InspectorImpl* m_inspector;
int m_contextGroupId;
int m_estimatedSize = 0;
std::deque<std::unique_ptr<V8ConsoleMessage>> m_messages;
-
- struct PerContextData {
- std::set<String16> m_reportedDeprecationMessages;
- std::map<String16, int> m_count;
- std::map<String16, double> m_time;
- };
- std::map<int, PerContextData> m_data;
};
} // namespace v8_inspector
« no previous file with comments | « src/inspector/v8-console.cc ('k') | src/inspector/v8-console-message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698