📰 Handle ReadFromDisk violations in AllDismissed item

[NTP Client] Handle ReadFromDisk violations in AllDismissed item

In instrumentation tests Calendar#getInstance can trigger StrictMode
violations, which make tests fail. This patch allows temporarily disk
access when obtaining the Calendar instance to avoid these flakes

BUG=705477

[dgn, 2017-03-27 11:08:47]

Description was changed from

==========
[NTP Client] Handle ReadFromDisk violations in AllDismissed item

In instrumentation tests Calendar#getInstance can trigger StrictMode
violations, which make tests fail. This patch allows temporarily disk
access when obtaining the Calendar instance to avoid these flakes

BUG=705477
==========

to

==========
[NTP Client] Handle ReadFromDisk violations in AllDismissed item

In instrumentation tests Calendar#getInstance can trigger StrictMode
violations, which make tests fail. This patch allows temporarily disk
access when obtaining the Calendar instance to avoid these flakes

BUG=705477
==========

[dgn, 2017-03-27 11:09:00]

dgn@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[dgn, 2017-03-27 11:09:01]

PTAL

[dgn, 2017-03-27 11:09:08]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 11:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 11:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 11:44:36]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-03-27 11:57:40]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2017-03-27 11:57:41]

https://codereview.chromium.org/2778743002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
(right):

https://codereview.chromium.org/2778743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java:77:
* during instrumentation tests. See https://crbug.com/705477 and
http://crbug.com/577185
Nit: https for both links :)

[Michael van Ouwerkerk, 2017-03-27 16:24:29]

lgtm

[dgn, 2017-03-30 14:16:56]

Abandoned in favour of https://codereview.chromium.org/2779593003/ that doesn't
affect production code.