Remove navigator.vibrate without user gesture.

third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt

Index: third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt
diff --git a/third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt b/third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt
index bf6892f75900d50809729fbf005400053637ddf0..8bc34f591a8fb2374d3436adefb11d27c4182cde 100644
--- a/third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt
+++ b/third_party/WebKit/LayoutTests/vibration/vibration-durations-expected.txt
@@ -1,3 +1,19 @@
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.

[Rick Byers, 2017/03/29 18:01:40]

I think you want to change the test to simulate a user gesture, since that's
really the codepath the tests intend to validate.  Then we can avoid adding all
these warnings to the expected output.

Ideally you'd have at least one test which intentionally doesn't have a gesture
to test the error message and eventual failure.

Note that often we'll de-dupe warnings to prevent a frequently called API from
generating an infinite number.  The risk here seems low with vibrate so it's
probably better as-is, but thought it was worth mentioning.

[binlu, 2017/04/11 21:54:25]

Done:
(1) Made changes to the tests to simulate user click via adding a
user-gesture-utils.js file in  third_party/WebKit/LayoutTests/resources.
(2) Added another test to test the cases of before/during/after user click on
the top page:
http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html

Any pointer on how to de-dupe warnings (even if we don't need it for this
change)?


On 2017/03/29 18:01:40, Rick Byers wrote:

[Rick Byers, 2017/04/14 01:09:13]

You could use the machinery in Deprecation.cpp (which relies on UseCounter.cpp
to keep track of the usage seen per Page since the last page load).

+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.

[Rick Byers, 2017/03/29 18:01:40]

Why are we getting this version of the warning when status=experimental features
are enabled by default for LayoutTests (outside virtual/stable)?  Shouldn't we
be getting the "has been blocked" warning?

[binlu, 2017/04/11 21:54:25]

Is my understanding right that it says "content_shell will not enable
experimental/test features by default ..." according to
https://www.chromium.org/blink/runtime-enabled-features.

Anyway, I changed the experiment feature to FEATURE_ENABLED_BY_DEFAULT (from
XXX_DISABLED_BY_DEFAULT), and so we see the "has been blocked" warning.
Please let me know if I'm doing it wrong. Thanks.


On 2017/03/29 18:01:40, Rick Byers wrote:

[Rick Byers, 2017/04/14 01:09:13]

That page is confusing, sorry.  Running layout tests DOES run with the
--dump-render-tree flag (although it's actually called --run-layout-test now). 
So LayoutTests have status=test (and experimental) enabled by default except
inside the virtual/stable virtual test suite.
Have you verified that running your Chrome build manually you don't now get the
experimental behavior enabled?  You don't want to accidentally ship this just
yet ;-).  The tests should be testing what we expect to ship in M60 and you
should manually verify that (other than warnings) things behave as before in
M59.  If necessary we can add tests to the 'stable' testsuite to also test the
M59 behavior but I don't think it's worth worrying about.

+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 1: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
+CONSOLE WARNING: line 17: A call to navigator.vibrate will soon require user tap on the frame or any embedded frame:https://www.chromestatus.com/feature/5644273861001216.
 Tests for how durations are handled in the Vibration API.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".