Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html

Issue 2778693004: Remove navigator.vibrate without user gesture. (Closed)
Patch Set: refactor SimulateUserClick Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html ('K') | « third_party/WebKit/LayoutTests/vibration/vibration-durations.html ('k') | third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt » ('j') | third_party/WebKit/LayoutTests/vibration/vibration-patterns.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
diff --git a/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html b/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
index ee16c08ea9b7958fec472fb8b58f34fad2f61c15..66c16476c7ef264e6ad10fd62d9d2a9a06e0a3f9 100644
--- a/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
+++ b/third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html
@@ -1,12 +1,19 @@
<html>
<head>
<script src="../resources/js-test.js"></script>
+<script src="../resources/user-gesture-utils.js"></script>
<script src="vibration-utils.js"></script>
</head>
<body>
+<h4 id="test"></h4>
<script>
description('Tests that bad input throws exceptions in the Vibration API.');
+// Simulates a user click for vibrate to be allowed.
+// See: https://www.chromestatus.com/feature/5644273861001216.
+var element = document.getElementById("test");
+simulateUserClick(element.offsetLeft + 2, element.offsetTop + 2);
+
shouldThrow("navigator.vibrate()");
shouldBe("navigator.vibrate(1, 2)", "true");
shouldBe("navigator.vibrate([1], [2])", "true");
« third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html ('K') | « third_party/WebKit/LayoutTests/vibration/vibration-durations.html ('k') | third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt » ('j') | third_party/WebKit/LayoutTests/vibration/vibration-patterns.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698