third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html - Issue 2778693004: Remove navigator.vibrate without user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html

Issue 2778693004: Remove navigator.vibrate without user gesture. (Closed)

Patch Set: refactor SimulateUserClick Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html ('K') | « third_party/WebKit/LayoutTests/resources/user-gesture-utils.js ('k') | third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html » ('j') | third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html

diff --git a/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html b/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html

index d41c40549a53efe0ce8a11beb23b23e9423e35aa..f5bc41f86923878d186e9ba54964a863e0b9630e 100644

--- a/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html

+++ b/third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html

@@ -1,11 +1,19 @@

<html>

<head>

+<script src="../resources/user-gesture-utils.js"></script>

+<script src="vibration-utils.js"></script>

</head>

<body>

+<h4 id="test"></h4>

description('Tests the cancelVibration during pattern vibration is working.');

+// Simulates a user click for vibrate to be allowed.

+// See: https://www.chromestatus.com/feature/5644273861001216.

+var element = document.getElementById("test");

+simulateUserClick(element.offsetLeft + 2, element.offsetTop + 2);

function vibrate(pattern) {

navigator.vibrate(pattern);

shouldBeTrue('internals.isVibrating(navigator)');

@@ -60,4 +68,4 @@ if (window.testRunner) {

}

</script>

</body>

-</html>

+</html>