Remove navigator.vibrate without user gesture.

third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #include "modules/vibration/NavigatorVibration.h"
 
 #include "core/dom/Document.h"
+#include "core/frame/FrameConsole.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Navigator.h"
 #include "core/frame/UseCounter.h"
+#include "core/inspector/ConsoleMessage.h"
 #include "core/page/Page.h"
 #include "modules/vibration/VibrationController.h"
 #include "platform/Histogram.h"
 #include "platform/UserGestureIndicator.h"
 #include "public/platform/site_engagement.mojom-blink.h"
 
 namespace blink {
 
 NavigatorVibration::NavigatorVibration(Navigator& navigator)
     : ContextLifecycleObserver(navigator.GetFrame()->GetDocument()) {}
@@ skipping 45 matching lines @@
   // runtime flag. Please pay attention to the user gesture code below.
   if (RuntimeEnabledFeatures::featurePolicyEnabled() &&
       RuntimeEnabledFeatures::featurePolicyExperimentalFeaturesEnabled() &&
       !frame->IsFeatureEnabled(blink::WebFeaturePolicyFeature::kVibrate)) {
     frame->DomWindow()->PrintErrorMessage(
         "Navigator.vibrate() is not enabled in feature policy for this "
         "frame.");
     return false;
   }
 
-  if (!RuntimeEnabledFeatures::featurePolicyEnabled() &&
-      frame->IsCrossOriginSubframe() && !frame->HasReceivedUserGesture()) {
-    frame->DomWindow()->PrintErrorMessage(
-        "Blocked call to navigator.vibrate inside a cross-origin iframe "
-        "because the frame has never been activated by the user: "
-        "https://www.chromestatus.com/feature/5682658461876224.");
-    return false;
+  if (!frame->HasReceivedUserGesture()) {

[mustaq, 2017/04/13 19:05:04]

Clarification question: why you don't want this to depend on
featurePolicyEnabled() now?

[binlu, 2017/04/13 19:55:27]

FeaturePolicy is being turned on by default for other features (but not
vibrate), and also the check will run before the user gesture check.

+    String message;
+    MessageLevel level = kErrorMessageLevel;
+    if (frame->IsCrossOriginSubframe()) {
+      message =
+          "Blocked call to navigator.vibrate inside a cross-origin "
+          "iframe because the frame has never been activated by the user: "
+          "https://www.chromestatus.com/feature/5682658461876224.";
+    } else if (RuntimeEnabledFeatures::vibrateRequiresUserGestureEnabled()) {
+      message =
+          "Blocked call to navigator.vibrate because user hasn't tapped "
+          "on the frame or any embedded frame yet: "
+          "https://www.chromestatus.com/feature/5644273861001216.";
+    } else {  // Just print a warning.
+      level = kWarningMessageLevel;
+      message =
+          "A call to navigator.vibrate will soon require user tap on "
+          "the frame or any embedded frame: "
+          "https://www.chromestatus.com/feature/5644273861001216.";
+    }
+
+    frame->DomWindow()->GetFrameConsole()->AddMessage(
+        ConsoleMessage::Create(kInterventionMessageSource, level, message));
+    if (level == kErrorMessageLevel) {
+      return false;
+    }
   }
 
   return NavigatorVibration::From(navigator).Controller(*frame)->Vibrate(
       pattern);
 }
 
 // static
 void NavigatorVibration::CollectHistogramMetrics(const LocalFrame& frame) {
   NavigatorVibrationType type;
   bool user_gesture = frame.HasReceivedUserGesture();
@@ skipping 57 matching lines @@
   }
 }
 
 DEFINE_TRACE(NavigatorVibration) {
   visitor->Trace(controller_);
   Supplement<Navigator>::Trace(visitor);
   ContextLifecycleObserver::Trace(visitor);
 }
 
 }  // namespace blink