third_party/WebKit/LayoutTests/vibration/vibration-patterns.html - Issue 2778693004: Remove navigator.vibrate without user gesture.

Side by Side Diff: third_party/WebKit/LayoutTests/vibration/vibration-patterns.html

Issue 2778693004: Remove navigator.vibrate without user gesture. (Closed)

Patch Set: refactor SimulateUserClick Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html ('K') | « third_party/WebKit/LayoutTests/vibration/vibration-page-visibility.html ('k') | third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp » ('j') | third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../resources/js-test.js"></script>	3 <script src="../resources/js-test.js"></script>

	4 <script src="../resources/user-gesture-utils.js"></script>

4 <script src="vibration-utils.js"></script>	5 <script src="vibration-utils.js"></script>

5 </head>	6 </head>

6 <body>	7 <body>

	8 <h4 id="test"></h4>

7 <script>	9 <script>

8 description('Tests for how patterns are handled in the Vibration API.');	10 description('Tests for how patterns are handled in the Vibration API.');

9	11

	12 // Simulates a user click for vibrate to be allowed.

	13 // See: https://www.chromestatus.com/feature/5644273861001216.
	mustaq 2017/04/13 19:05:04 The chromestatus links here seem redundant because The chromestatus links here seem redundant because the same link is there in the main code as well as in console messages. Please remove all such links from html comments. binlu 2017/04/13 19:55:27 Will remove them shortly. Show quoted text On 2017/04/13 19:05:04, mustaq wrote: > The chromestatus links here seem redundant because the same link is there in the > main code as well as in console messages. Please remove all such links from > html comments. Will remove them shortly. binlu 2017/04/18 15:48:29 Done. Show quoted text On 2017/04/13 19:55:27, binlu wrote: > On 2017/04/13 19:05:04, mustaq wrote: > > The chromestatus links here seem redundant because the same link is there in > the > > main code as well as in console messages. Please remove all such links from > > html comments. > > Will remove them shortly. Done.
	14 var element = document.getElementById("test");

	15 simulateUserClick(element.offsetLeft + 2, element.offsetTop + 2);

	16

10 // A trailing pause is discarded from a pattern i.e. patterns of even	17 // A trailing pause is discarded from a pattern i.e. patterns of even

11 // non-zero length are truncated by 1.	18 // non-zero length are truncated by 1.

12 shouldBeTrue("navigator.vibrate(newPattern(1, 4))");	19 shouldBeTrue("navigator.vibrate(newPattern(1, 4))");

13 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 3))");	20 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 3))");

14 shouldBeTrue("internals.isVibrating(navigator)");	21 shouldBeTrue("internals.isVibrating(navigator)");

15 stopVibration();	22 stopVibration();

16	23

17 // Maximum pattern length.	24 // Maximum pattern length.

18 shouldBeTrue("navigator.vibrate(newPattern(1, 99))");	25 shouldBeTrue("navigator.vibrate(newPattern(1, 99))");

19 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 99))");	26 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 99))");

20 shouldBeTrue("internals.isVibrating(navigator)");	27 shouldBeTrue("internals.isVibrating(navigator)");

21 stopVibration();	28 stopVibration();

22	29

23 // The pattern is longer than supported. It is truncated and execution proceeds.	30 // The pattern is longer than supported. It is truncated and execution proceeds.

24 shouldBeTrue("navigator.vibrate(newPattern(1, 200))");	31 shouldBeTrue("navigator.vibrate(newPattern(1, 200))");

25 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 99))");	32 shouldBeTrue("areArraysEqual(internals.pendingVibrationPattern(navigator), newPa ttern(1, 99))");

26 shouldBeTrue("internals.isVibrating(navigator)");	33 shouldBeTrue("internals.isVibrating(navigator)");

27 stopVibration();	34 stopVibration();

28	35

29 </script>	36 </script>

30 </body>	37 </body>

31 </html>	38 </html>

OLD	NEW