Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc

Issue 2778683002: Disable flaky CanMakePayment_NotSupported_Incognito (Closed)
Patch Set: o Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h" 9 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h"
10 #include "components/autofill/core/browser/autofill_test_utils.h" 10 #include "components/autofill/core/browser/autofill_test_utils.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 const autofill::CreditCard card = autofill::test::GetCreditCard2(); // Amex. 65 const autofill::CreditCard card = autofill::test::GetCreditCard2(); // Amex.
66 AddCreditCard(card); 66 AddCreditCard(card);
67 67
68 CallCanMakePayment(); 68 CallCanMakePayment();
69 69
70 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("false")}); 70 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("false")});
71 } 71 }
72 72
73 // Visa is required, and user doesn't have a visa instrument and the user is in 73 // Visa is required, and user doesn't have a visa instrument and the user is in
74 // incognito mode. 74 // incognito mode.
75 // Test is flaky. crbug.com/705271 75 // Test is flaky on ChromeOS. crbug.com/705271
76 #if defined(OS_CHROMEOS)
77 #define MAYBE_CanMakePayment_NotSupported_Incognito \
78 DISABLED_CanMakePayment_NotSupported_Incognito
79 #else
80 #define MAYBE_CanMakePayment_NotSupported_Incognito \
81 CanMakePayment_NotSupported_Incognito
82 #endif
76 IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryTest, 83 IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryTest,
77 DISABLED_CanMakePayment_NotSupported_Incognito) { 84 MAYBE_CanMakePayment_NotSupported_Incognito) {
78 SetIncognitoForTesting(); 85 SetIncognitoForTesting();
79 86
80 const autofill::CreditCard card = autofill::test::GetCreditCard2(); // Amex. 87 const autofill::CreditCard card = autofill::test::GetCreditCard2(); // Amex.
81 AddCreditCard(card); 88 AddCreditCard(card);
82 89
83 CallCanMakePayment(); 90 CallCanMakePayment();
84 91
85 // Returns true because the user is in incognito mode, even though it should 92 // Returns true because the user is in incognito mode, even though it should
86 // return false in a normal profile. 93 // return false in a normal profile.
87 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")}); 94 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")});
88 } 95 }
89 96
90 } // namespace payments 97 } // namespace payments
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698