[typedarrays] Check detached buffer at start of typed array methods

test/mjsunit/regress/regress-353004.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax
 
 var buffer1 = new ArrayBuffer(100 * 1024);
 
 var array1 = new Uint8Array(buffer1, {valueOf : function() {
   %ArrayBufferNeuter(buffer1);
@@ skipping 41 matching lines @@
 var buffer7 = new ArrayBuffer(100 * 1024 * 1024);
 assertThrows(function() {
   buffer7.slice(0, {valueOf : function() {
     %ArrayBufferNeuter(buffer7);
     return 100 * 1024 * 1024;
   }});
 }, TypeError);
 
 var buffer9 = new ArrayBuffer(1024);
 var array9 = new Uint8Array(buffer9);
-var array10 = array9.subarray({valueOf : function() {
+assertThrows(() =>
+  array9.subarray({valueOf : function() {
     %ArrayBufferNeuter(buffer9);
     return 0;
-  }}, 1024);
+  }}, 1024), TypeError);
 assertEquals(0, array9.length);
-assertEquals(0, array10.length);
-
-var buffer11 = new ArrayBuffer(1024);
-var array11 = new Uint8Array(buffer11);
-var array12 = array11.subarray(0, {valueOf : function() {
-      %ArrayBufferNeuter(buffer11);
-      return 1024;
-    }});
-assertEquals(0, array11.length);
-assertEquals(0, array12.length);

[Dan Ehrenberg, 2017/03/28 19:39:28]

Rather than deleting the test, can you change it to expect what's the new
current behavior? In this case, it should throw a TypeError.

[Choongwoo Han, 2017/03/29 05:36:54]

Done.