[typedarrays] Check detached buffer at start of typed array methods

src/js/typedarray.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
 // -------------------------------------------------------------------
 // Imports
 
 // array.js has to come before typedarray.js for this to work
 var ArrayToString = utils.ImportNow("ArrayToString");
-var ArrayValues;
 var GetIterator;
 var GetMethod;
 var GlobalArray = global.Array;
 var GlobalArrayBuffer = global.ArrayBuffer;
 var GlobalArrayBufferPrototype = GlobalArrayBuffer.prototype;
 var GlobalObject = global.Object;
 var InnerArrayFilter;
 var InnerArrayFind;
 var InnerArrayFindIndex;
 var InnerArrayJoin;
@@ skipping 23 matching lines @@
 
 macro DECLARE_GLOBALS(INDEX, NAME, SIZE)
 var GlobalNAME = global.NAME;
 endmacro
 
 TYPED_ARRAYS(DECLARE_GLOBALS)
 
 var GlobalTypedArray = %object_get_prototype_of(GlobalUint8Array);
 
 utils.Import(function(from) {
-  ArrayValues = from.ArrayValues;
   GetIterator = from.GetIterator;
   GetMethod = from.GetMethod;
   InnerArrayFilter = from.InnerArrayFilter;
   InnerArrayFind = from.InnerArrayFind;
   InnerArrayFindIndex = from.InnerArrayFindIndex;
   InnerArrayJoin = from.InnerArrayJoin;
   InnerArraySort = from.InnerArraySort;
   InnerArrayToLocaleString = from.InnerArrayToLocaleString;
   MaxSimple = from.MaxSimple;
   MinSimple = from.MinSimple;
@@ skipping 17 matching lines @@
   throw %make_type_error(kIncompatibleMethodReceiver,
                       "TypedArrayDefaultConstructor", this);
 }
 
 function TypedArrayCreate(constructor, arg0, arg1, arg2) {
   if (IS_UNDEFINED(arg1)) {
     var newTypedArray = new constructor(arg0);
   } else {
     var newTypedArray = new constructor(arg0, arg1, arg2);
   }
-  if (!IS_TYPEDARRAY(newTypedArray)) throw %make_type_error(kNotTypedArray);
-  // TODO(littledan): Check for being detached, here and elsewhere
-  // All callers where the first argument is a Number have no additional
-  // arguments.
+  %ValidateTypedArray(newTypedArray, "TypedArrayCreate");

[adamk, 2017/03/27 19:48:20]

I'm worried that adding a runtime call here might slow down construction. Is
there any perf testing you've done on this change?

[Choongwoo Han, 2017/03/28 09:50:58]

Actually this function is not related with default construction (new
TypedArray(..)), but is called from subarray, .of, .from.

   if (IS_NUMBER(arg0) && %_TypedArrayGetLength(newTypedArray) < arg0) {
     throw %make_type_error(kTypedArrayTooShort);
   }
   return newTypedArray;
 }
 
-function TypedArraySpeciesCreate(exemplar, arg0, arg1, arg2, conservative) {
+function TypedArraySpeciesCreate(exemplar, arg0, arg1, arg2) {
   var defaultConstructor = TypedArrayDefaultConstructor(exemplar);
-  var constructor = SpeciesConstructor(exemplar, defaultConstructor,
-                                       conservative);
+  var constructor = SpeciesConstructor(exemplar, defaultConstructor);
   return TypedArrayCreate(constructor, arg0, arg1, arg2);
 }
 
 macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)
 function NAMEConstructByIterable(obj, iterable, iteratorFn) {
   var list = new InternalArray();
   // Reading the Symbol.iterator property of iterable twice would be
   // observable with getters, so instead, we call the function which
   // was already looked up, and wrap it in another iterable. The
   // __proto__ of the new iterable is set to null to avoid any chance
@@ skipping 72 matching lines @@
     endInt = MinSimple(endInt, srcLength);
   }
 
   if (endInt < beginInt) {
     endInt = beginInt;
   }
 
   var newLength = endInt - beginInt;
   var beginByteOffset =
       %_ArrayBufferViewGetByteOffset(this) + beginInt * ELEMENT_SIZE;
-  // BUG(v8:4665): For web compatibility, subarray needs to always build an
-  // instance of the default constructor.
-  // TODO(littledan): Switch to the standard or standardize the fix
-  return new GlobalNAME(%TypedArrayGetBuffer(this), beginByteOffset, newLength);
+  return TypedArraySpeciesCreate(this, %TypedArrayGetBuffer(this),
+                                 beginByteOffset, newLength);
 }
 endmacro
 
 TYPED_ARRAYS(TYPED_ARRAY_CONSTRUCTOR)
 
 function TypedArraySubArray(begin, end) {
   switch (%_ClassOf(this)) {
 macro TYPED_ARRAY_SUBARRAY_CASE(ARRAY_ID, NAME, ELEMENT_SIZE)
     case "NAME":
       return %_Call(NAMESubArray, this, begin, end);
@@ skipping 126 matching lines @@
     if (i in array) {
       var element = array[i];
       if (!%_Call(f, receiver, element, i, array)) return false;
     }
   }
   return true;
 }
 
 // ES6 draft 05-05-15, section 22.2.3.7
 function TypedArrayEvery(f, receiver) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.every");

[adamk, 2017/03/27 19:48:20]

Hmm, again this is likely to be much more expensive than the previous check.

[Choongwoo Han, 2017/03/28 09:50:58]

Yes, it was too expensive than my expectation (2x overhead). So, I updated to
keep using the inline typed array check, and additional neutered checks through
runtime call. this is 5% overhead when I run the following minimal benchmark in
my machine.

```test.js
var arr = new Uint8Array(1024);

var t = performance.now();
for (var i = 0; i < 10000000; i++) {
  arr.every((v) => false)
}
print(performance.now() - t);
```
before: 896.7108000000001 (on average)
after: 939.5634 (on average)
939.5634 / 896.7108000000001 = 1.0477886515920183

 
   var length = %_TypedArrayGetLength(this);
 
   return InnerTypedArrayEvery(f, receiver, this, length);
 }
 %FunctionSetLength(TypedArrayEvery, 1);
 
 function InnerTypedArrayForEach(f, receiver, array, length) {
   if (!IS_CALLABLE(f)) throw %make_type_error(kCalledNonCallable, f);
 
   if (IS_UNDEFINED(receiver)) {
     for (var i = 0; i < length; i++) {
       if (i in array) {
         var element = array[i];
         f(element, i, array);
       }
     }
   } else {
     for (var i = 0; i < length; i++) {
       if (i in array) {
         var element = array[i];
         %_Call(f, receiver, element, i, array);
       }
     }
   }
 }
 
 // ES6 draft 08-24-14, section 22.2.3.12
 function TypedArrayForEach(f, receiver) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.forEach");
 
   var length = %_TypedArrayGetLength(this);
 
   InnerTypedArrayForEach(f, receiver, this, length);
 }
 %FunctionSetLength(TypedArrayForEach, 1);
 
 
 // ES6 draft 07-15-13, section 22.2.3.9
 function TypedArrayFilter(f, thisArg) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypeArray.prototype.filter");
 
   var length = %_TypedArrayGetLength(this);
   if (!IS_CALLABLE(f)) throw %make_type_error(kCalledNonCallable, f);
   var result = new InternalArray();
   InnerArrayFilter(f, thisArg, this, length, result);
   var captured = result.length;
   var output = TypedArraySpeciesCreate(this, captured);
   for (var i = 0; i < captured; i++) {
     output[i] = result[i];
   }
   return output;
 }
 %FunctionSetLength(TypedArrayFilter, 1);
 
 
 // ES6 draft 07-15-13, section 22.2.3.10
 function TypedArrayFind(predicate, thisArg) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.find");
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerArrayFind(predicate, thisArg, this, length);
 }
 %FunctionSetLength(TypedArrayFind, 1);
 
 
 // ES6 draft 07-15-13, section 22.2.3.11
 function TypedArrayFindIndex(predicate, thisArg) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.findIndex");
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerArrayFindIndex(predicate, thisArg, this, length);
 }
 %FunctionSetLength(TypedArrayFindIndex, 1);
 
 
 // ES6 draft 05-18-15, section 22.2.3.25
 function TypedArraySort(comparefn) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.sort");
 
   var length = %_TypedArrayGetLength(this);
 
   if (IS_UNDEFINED(comparefn)) {
     return %TypedArraySortFast(this);
   }
 
   return InnerArraySort(this, length, comparefn);
 }
 
 
 // ES6 draft 07-15-13, section 22.2.3.18
 function TypedArrayMap(f, thisArg) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.map");
 
   var length = %_TypedArrayGetLength(this);
   var result = TypedArraySpeciesCreate(this, length);
   if (!IS_CALLABLE(f)) throw %make_type_error(kCalledNonCallable, f);
   for (var i = 0; i < length; i++) {
     var element = this[i];
     result[i] = %_Call(f, thisArg, element, i, this);
   }
   return result;
 }
 %FunctionSetLength(TypedArrayMap, 1);
 
 function InnerTypedArraySome(f, receiver, array, length) {
   if (!IS_CALLABLE(f)) throw %make_type_error(kCalledNonCallable, f);
 
   for (var i = 0; i < length; i++) {
     if (i in array) {
       var element = array[i];
       if (%_Call(f, receiver, element, i, array)) return true;
     }
   }
   return false;
 }
 
 // ES6 draft 05-05-15, section 22.2.3.24
 function TypedArraySome(f, receiver) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.some");
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerTypedArraySome(f, receiver, this, length);
 }
 %FunctionSetLength(TypedArraySome, 1);
 
 
 // ES6 section 22.2.3.27
 function TypedArrayToLocaleString() {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.toLocaleString");
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerArrayToLocaleString(this, length);
 }
 
 
 // ES6 section 22.2.3.14
 function TypedArrayJoin(separator) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.join");
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerArrayJoin(separator, this, length);
 }
 
 function InnerTypedArrayReduce(
     callback, current, array, length, argumentsLength) {
   if (!IS_CALLABLE(callback)) {
     throw %make_type_error(kCalledNonCallable, callback);
@@ skipping 14 matching lines @@
     if (i in array) {
       var element = array[i];
       current = callback(current, element, i, array);
     }
   }
   return current;
 }
 
 // ES6 draft 07-15-13, section 22.2.3.19
 function TypedArrayReduce(callback, current) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.reduce");
 
   var length = %_TypedArrayGetLength(this);
   return InnerTypedArrayReduce(
       callback, current, this, length, arguments.length);
 }
 %FunctionSetLength(TypedArrayReduce, 1);
 
 function InnerArrayReduceRight(callback, current, array, length,
                                argumentsLength) {
   if (!IS_CALLABLE(callback)) {
@@ skipping 15 matching lines @@
     if (i in array) {
       var element = array[i];
       current = callback(current, element, i, array);
     }
   }
   return current;
 }
 
 // ES6 draft 07-15-13, section 22.2.3.19
 function TypedArrayReduceRight(callback, current) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.reduceRight");
 
   var length = %_TypedArrayGetLength(this);
   return InnerArrayReduceRight(callback, current, this, length,
                                arguments.length);
 }
 %FunctionSetLength(TypedArrayReduceRight, 1);
 
 
 function TypedArraySlice(start, end) {
-  if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
+  %ValidateTypedArray(this, "TypedArray.prototype.slice");
+
   var len = %_TypedArrayGetLength(this);
 
   var relativeStart = TO_INTEGER(start);
 
   var k;
   if (relativeStart < 0) {
     k = MaxSimple(len + relativeStart, 0);
   } else {
     k = MinSimple(relativeStart, len);
   }
@@ skipping 134 matching lines @@
   %AddNamedProperty(GlobalNAME.prototype,
                     "constructor", global.NAME, DONT_ENUM);
   %AddNamedProperty(GlobalNAME.prototype,
                     "BYTES_PER_ELEMENT", ELEMENT_SIZE,
                     READ_ONLY | DONT_ENUM | DONT_DELETE);
 endmacro
 
 TYPED_ARRAYS(SETUP_TYPED_ARRAY)
 
 })