Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2277)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java

Issue 2778613002: Display LinkText/TitleText (bold) + LinkUrl/SrcUrl in ContextMenu title
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
index 2cef7608b9aa226d8f5133ffae0d963dae3112f0..2e8332a4f36aa238aaef45047f2f3d765feaf98c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuTitleView.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.contextmenu;
import android.content.Context;
+import android.text.SpannableStringBuilder;
import android.text.TextUtils;
import android.widget.ScrollView;
import android.widget.TextView;
@@ -27,7 +28,7 @@ public class ContextMenuTitleView extends ScrollView {
* @param context Context to be used to inflate this view.
* @param title String to be displayed as the title.
*/
- public ContextMenuTitleView(Context context, String title) {
+ public ContextMenuTitleView(Context context, SpannableStringBuilder title) {
super(context);
mDpToPx = getContext().getResources().getDisplayMetrics().density;
int padding = (int) (PADDING_DP * mDpToPx);
@@ -35,10 +36,7 @@ public class ContextMenuTitleView extends ScrollView {
TextView titleView = new TextView(context);
if (!TextUtils.isEmpty(title) && title.length() > MAX_TITLE_CHARS) {
- StringBuilder sb = new StringBuilder(MAX_TITLE_CHARS + ELLIPSIS.length());
- sb.append(title, 0, MAX_TITLE_CHARS);
- sb.append(ELLIPSIS);
- title = sb.toString();
+ title.append(ELLIPSIS);
}
titleView.setText(title);
titleView.setTextColor(ApiCompatibilityUtils.getColor(getResources(),

Powered by Google App Engine
This is Rietveld 408576698