Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2778553002: CrOS download warning should say 'dangerous' instead of 'malicious' (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS download warning should say 'dangerous' instead of 'malicious' to be consistent with download warnings on other platforms. BUG=705069 Review-Url: https://codereview.chromium.org/2778553002 Cr-Commit-Position: refs/heads/master@{#460200} Committed: https://chromium.googlesource.com/chromium/src/+/ac0db0c0784da2106c18be21615659ed4cc25c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Jialiu Lin
Hi emilyschechter@, nparker@, Since M55 we replaced the word "malicious" with "dangerous" in download warning ...
3 years, 9 months ago (2017-03-24 23:49:08 UTC) #6
Nathan Parker
lgtm
3 years, 9 months ago (2017-03-27 17:23:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778553002/1
3 years, 8 months ago (2017-03-28 19:01:09 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 20:17:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac0db0c0784da2106c18be216156...

Powered by Google App Engine
This is Rietveld 408576698