Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2901)

Issue 277853002: Change [Global=ServiceWorker] to [Global=Worker&ServiceWorker] in ServiceWorkerGlobalScope.idl (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken, kinuko
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Change [Global=ServiceWorker] to [Global=Worker&ServiceWorker] in ServiceWorkerGlobalScope.idl ServiceWorker should see everything in Worker, just as DedicatedWorker and SharedWorker already do, per Kinuko: https://code.google.com/p/chromium/issues/detail?id=369115#c3 http://heycam.github.io/webidl/#Global R=kinuko TBR=haraken BUG=369115 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
'ere you go!
6 years, 7 months ago (2014-05-09 06:08:44 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-09 06:09:54 UTC) #2
kinuko
lgtm, thanks!
6 years, 7 months ago (2014-05-09 06:10:02 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-09 06:12:54 UTC) #4
Nils Barth (inactive)
n/p, glad to help!
6 years, 7 months ago (2014-05-09 06:13:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/277853002/1
6 years, 7 months ago (2014-05-09 06:14:44 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 07:23:51 UTC) #7
Message was sent while issue was closed.
Change committed as 173732

Powered by Google App Engine
This is Rietveld 408576698