Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/win/jumplist_file_util.h

Issue 2778513002: Delete JumpListIconsOld and update revised links in every update (Closed)
Patch Set: Update jumplist links anyway Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/win/jumplist_file_util.h
diff --git a/chrome/browser/win/jumplist_file_util.h b/chrome/browser/win/jumplist_file_util.h
index ec618162aa256fcb35c3043ea52cd6b481928141..da37c4f5630c7d4c611e6d4fa9b356ec546883f0 100644
--- a/chrome/browser/win/jumplist_file_util.h
+++ b/chrome/browser/win/jumplist_file_util.h
@@ -5,10 +5,10 @@
#ifndef CHROME_BROWSER_WIN_JUMPLIST_FILE_UTIL_H_
#define CHROME_BROWSER_WIN_JUMPLIST_FILE_UTIL_H_
-#include "base/files/file_path.h"
+#include "base/files/file_util.h"
// Maximum number of icon files allowed to delete per jumplist update.
-const int kFileDeleteLimit = 100;
+const int kFileDeleteLimit = 60;
grt (UTC plus 2) 2017/03/27 19:18:48 why lower this? do metrics indicate that 100 is to
chengx 2017/03/27 20:26:08 For users having no trouble in using Chrome, 60 an
// Folder delete status enumeration, used in Delete* methods below.
// This is used for UMA. Do not delete entries, and keep in sync with
@@ -36,14 +36,15 @@ enum FolderDeleteResult {
END
};
-// An enumeration indicating if a directory is empty or not.
+// An enumeration indicating if a directory exists or if it is empty or not.
// This is used for UMA. Do not delete entries, and keep in sync with
// histograms.xml.
-enum DirectoryEmptyStatus {
+enum DirectoryStatus {
EMPTY = 0,
NON_EMPTY,
+ NON_EXIST,
// Add new items before this one, always keep this one at the end.
- EMPTY_STATUS_END
+ DIRECTORY_STATUS_END
};
// This method is similar to base::DeleteFileRecursive in

Powered by Google App Engine
This is Rietveld 408576698