Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2778463002: Fixed missing method referenced when MallocHooks is unsupported. (Closed)

Created:
3 years, 9 months ago by bkonyi
Modified:
3 years, 9 months ago
Reviewers:
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed missing method referenced when MallocHooks is unsupported. Added page to Observatory to display native memory allocation information. BUG= Committed: https://github.com/dart-lang/sdk/commit/a0b9c5a17809d38e8677004e9af93816aae9298d

Patch Set 1 #

Patch Set 2 : Fixed missing method referenced when MallocHooks is unsupported. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1074 lines, -204 lines) Patch
M runtime/observatory/lib/elements.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +20 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 18 chunks +132 lines, -22 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 10 chunks +109 lines, -15 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/native_memory_profiler.dart View 1 chunk +162 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/sample_profile.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/repositories/sample_profile.dart View 5 chunks +39 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +21 lines, -22 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/profiler.h View 9 chunks +61 lines, -1 line 0 comments Download
M runtime/vm/profiler.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M runtime/vm/profiler_service.h View 4 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 32 chunks +150 lines, -114 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +211 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 9 months ago (2017-03-24 16:34:56 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a0b9c5a17809d38e8677004e9af93816aae9298d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698