Issue 2778423002: Revert "[kernel] Don't use kernel ast nodes as keys"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2778423002: Revert "[kernel] Don't use kernel ast nodes as keys" (Closed)

Created:
3 years, 8 months ago by jensj

Modified:
3 years, 8 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "[kernel] Don't use kernel ast nodes as keys" Commit made everything go red. This reverts commit bc7200c392494a11f1df3f6b6df661d3fee27108. BUG= Committed: https://github.com/dart-lang/sdk/commit/1c4710469541ab27644b07535618e69605d4b548

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -97 lines)			Patch
M	runtime/vm/kernel.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View	15 chunks	+11 lines, -25 lines	0 comments	Download
M	runtime/vm/kernel_to_il.h	View	3 chunks	+3 lines, -51 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View	10 chunks	+10 lines, -14 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

Committed patchset #1 (id:1) manually as 1c4710469541ab27644b07535618e69605d4b548 (presubmit successful).

3 years, 8 months ago (2017-03-29 06:44:46 UTC) #4

Message was sent while issue was closed.

lgtm