ios/showcase/common/protocol_alerter.mm - Issue 2778343002: [Payment Request] Picker view + showcase integration + egtests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/showcase/common/protocol_alerter.mm

Issue 2778343002: [Payment Request] Picker view + showcase integration + egtests (Closed)

Patch Set: Addressed comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/showcase/common/protocol_alerter.mm

diff --git a/ios/showcase/common/protocol_alerter.mm b/ios/showcase/common/protocol_alerter.mm

index d1f420edc0ae844eecfa9012fc081ecda09aa2c4..0a27bbcdccf1038b781c881d52a538842cfcafc6 100644

--- a/ios/showcase/common/protocol_alerter.mm

+++ b/ios/showcase/common/protocol_alerter.mm

@@ -170,7 +170,7 @@ char kAssociatedProtocolNameKey;

// Return a string describing an argument at |index| that's known to be an

// objective-C object.

- (NSString*)objectDescriptionAtIndex:(NSInteger)index {

- id object;

+ __weak id object;

Moe 2017/03/29 17:04:09 without this the alerter deallocates the object ar

lpromero 2017/04/03 16:41:41 Indeed: http://stackoverflow.com/a/16932813 But pl

Moe 2017/04/05 05:09:49 Done.

[self getArgument:&object atIndex:index];

if (!object)