Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: tools/variations/fieldtrial_util_unittest.py

Issue 2778313003: Fix perfbotnot feature param setting from trial testing config. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/variations/fieldtrial_util.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/variations/fieldtrial_util_unittest.py
diff --git a/tools/variations/fieldtrial_util_unittest.py b/tools/variations/fieldtrial_util_unittest.py
index a215201a5fb43001544de8c5783d5435647b5639..5d118f0f8be20ce47f118f11cae2f5319d50da85 100644
--- a/tools/variations/fieldtrial_util_unittest.py
+++ b/tools/variations/fieldtrial_util_unittest.py
@@ -66,8 +66,8 @@ class FieldTrialUtilUnittest(unittest.TestCase):
'--force-fieldtrial-params='
'SimpleParams.Default:id/abc,'
'c.d%2E:url/http%3A%2F%2Fwww%2Egoogle%2Ecom',
- '--enable-features=a,b,x',
- '--disable-features=y'], result)
+ '--enable-features="a<SimpleParams,b<SimpleParams,x<c"',
+ '--disable-features="y<c"'], result)
perezju 2017/03/30 08:16:06 Are we sure that those quotes are needed there? T
Alexei Svitkine (slow) 2017/03/30 14:28:30 You're right that it might not be necessary, thoug
def test_DuplicateEnableFeatures(self):
config = '''{
« no previous file with comments | « tools/variations/fieldtrial_util.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698