Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2778313002: [memory-infra] Move periodic timer to dump thread

Created:
3 years, 8 months ago by ssid
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-infra] Move periodic timer to dump thread Sometimes TraceLog::SetDisable is not called on the same thread as the one that enabled. This causes a race in the periodic timer stop. To fix this, the timer is moved to the dump thread and handled just like polling tasks. BUG=702289, 702289, 706023

Patch Set 1 #

Patch Set 2 : nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -24 lines) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 5 chunks +19 lines, -6 lines 0 comments Download
M base/trace_event/memory_dump_scheduler.h View 1 4 chunks +13 lines, -5 lines 0 comments Download
M base/trace_event/memory_dump_scheduler.cc View 1 6 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ssid
Does it make sense?
3 years, 8 months ago (2017-03-28 19:00:24 UTC) #2
ssid
3 years, 8 months ago (2017-03-29 16:42:59 UTC) #3 
On 2017/03/28 19:00:24, ssid wrote:
> Does it make sense?

Ping.

Powered by Google App Engine
This is Rietveld 408576698