Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index 7a87448625ab79c028a90b47b2189eebd832b3f4..1d4462d1ced051bc50d7899ad6ec0241ed58ab7d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -32,12 +32,11 @@
/**
* @unrestricted
*/
-SDK.DOMNode = class extends SDK.SDKObject {
+SDK.DOMNode = class {
/**
* @param {!SDK.DOMModel} domModel
*/
constructor(domModel) {
- super(domModel.target());
this._domModel = domModel;
}
@@ -1077,6 +1076,13 @@ SDK.DOMModel = class extends SDK.SDKModel {
}
/**
+ * @return {!SDK.CSSModel}
+ */
+ cssModel() {
+ return /** @type {!SDK.CSSModel} */ (this.target().model(SDK.CSSModel));
+ }
+
+ /**
* @param {!SDK.RemoteObject} object
*/
static highlightObjectAsDOMNode(object) {
@@ -1085,21 +1091,8 @@ SDK.DOMModel = class extends SDK.SDKModel {
domModel.highlightDOMNode(undefined, undefined, undefined, object.objectId);
}
- /**
- * @return {!Array<!SDK.DOMModel>}
- */
- static instances() {
- var result = [];
- for (var target of SDK.targetManager.targets()) {
- var domModel = SDK.DOMModel.fromTarget(target);
- if (domModel)
- result.push(domModel);
- }
- return result;
- }
-
static hideDOMNodeHighlight() {
- for (var domModel of SDK.DOMModel.instances())
+ for (var domModel of SDK.targetManager.models(SDK.DOMModel))
domModel.highlightDOMNode(0);
}
@@ -1113,7 +1106,7 @@ SDK.DOMModel = class extends SDK.SDKModel {
}
static cancelSearch() {
- for (var domModel of SDK.DOMModel.instances())
+ for (var domModel of SDK.targetManager.models(SDK.DOMModel))
domModel._cancelSearch();
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698