third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js - Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

index 7a3040dc0699d9f4398bdf00ca41f9af968e2bef..ad633b22002bb6b49c83b381f481971dcd4ebc89 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

@@ -236,7 +236,7 @@ Elements.ElementsTreeOutline = class extends UI.TreeOutline {

if (this._clipboardNodeData.isCut && (node === targetNode || node.isAncestor(targetNode)))

return false;

- if (targetNode.target() !== node.target())

+ if (targetNode.domModel() !== node.domModel())

return false;

return true;

}

@@ -538,7 +538,7 @@ Elements.ElementsTreeOutline = class extends UI.TreeOutline {

var node = /** @type {!Elements.ElementsTreeElement} */ (listItem.treeElement).node();

var precomputedFeatures = await this._loadDimensionsForNode(node);

var preview = await Components.DOMPresentationUtils.buildImagePreviewContents(

- node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, precomputedFeatures);

+ node.domModel().target(), link[Elements.ElementsTreeElement.HrefSymbol], true, precomputedFeatures);

if (preview)

popover.contentElement.appendChild(preview);

return !!preview;