third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index 929774546621cce369abc3e854ecb2fbc9799c2b..a17edad69a34d02c30685419f4fa4a937e43189b 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -106,7 +106,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

static populateForcedPseudoStateItems(subMenu, node) {

const pseudoClasses = ['active', 'hover', 'focus', 'visited'];

- var forcedPseudoState = SDK.CSSModel.fromNode(node).pseudoState(node);

+ var forcedPseudoState = node.domModel().cssModel().pseudoState(node);

for (var i = 0; i < pseudoClasses.length; ++i) {

var pseudoClassForced = forcedPseudoState.indexOf(pseudoClasses[i]) >= 0;

subMenu.appendCheckboxItem(

@@ -119,7 +119,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

* @param {boolean} enabled

function setPseudoStateCallback(pseudoState, enabled) {

- SDK.CSSModel.fromNode(node).forcePseudoState(node, pseudoState, enabled);

+ node.domModel().cssModel().forcePseudoState(node, pseudoState, enabled);

}