Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index b4e0b566b02f9db9ee3e1782ce4cab545433db2c..884e7035d9f9405557701916cfd87a95fe057ae3 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -515,7 +515,7 @@ Elements.ElementsPanel = class extends UI.Panel {
this._searchConfig = searchConfig;
var promises = [];
- var domModels = SDK.DOMModel.instances();
+ var domModels = SDK.targetManager.models(SDK.DOMModel);
for (var domModel of domModels) {
promises.push(
domModel.performSearchPromise(whitespaceTrimmedQuery, Common.moduleSetting('showUAShadowDOM').get()));
@@ -585,7 +585,7 @@ Elements.ElementsPanel = class extends UI.Panel {
if (!node)
return false;
var preview = await Components.DOMPresentationUtils.buildImagePreviewContents(
- node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true);
+ node.domModel().target(), link[Elements.ElementsTreeElement.HrefSymbol], true);
if (preview)
popover.contentElement.appendChild(preview);
return !!preview;
@@ -1102,7 +1102,7 @@ Elements.ElementsPanel.PseudoStateMarkerDecorator = class {
decorate(node) {
return {
color: 'orange',
- title: Common.UIString('Element state: %s', ':' + SDK.CSSModel.fromNode(node).pseudoState(node).join(', :'))
+ title: Common.UIString('Element state: %s', ':' + node.domModel().cssModel().pseudoState(node).join(', :'))
};
}
};

Powered by Google App Engine
This is Rietveld 408576698