third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js - Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

index 2be799198b3443fb5388b9e3dcae7bff8e56f5f3..dbcc7703a9cc956a64a2b1124ab2633dbcc6c57a 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js

@@ -32,7 +32,7 @@ Elements.ComputedStyleModel = class extends Common.Object {

_onNodeChanged(event) {

this._node = /** @type {?SDK.DOMNode} */ (event.data);

- this._updateModel(this._node ? SDK.CSSModel.fromNode(this._node) : null);

+ this._updateModel(this._node ? this._node.domModel().cssModel() : null);

this._onComputedStyleChanged(null);

}

@@ -44,7 +44,7 @@ Elements.ComputedStyleModel = class extends Common.Object {

return;

Common.EventTarget.removeEventListeners(this._eventListeners);

this._cssModel = cssModel;

- var domModel = cssModel ? cssModel.target().model(SDK.DOMModel) : null;

+ var domModel = cssModel ? cssModel.domModel() : null;

var resourceTreeModel = cssModel ? cssModel.target().model(SDK.ResourceTreeModel) : null;

if (cssModel && domModel && resourceTreeModel) {

this._eventListeners = [