third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js - Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js ('k') | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

index 47778f525d0112fb692798a7276f19880f200936..75dae53c2b7dc39de888f459c8d3e5507deebc73 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

@@ -348,9 +348,7 @@ Animation.AnimationModel.Animation = class {

else

return;

- var cssModel = node.target().model(SDK.CSSModel);

- if (!cssModel)

- return;

+ var cssModel = node.domModel().cssModel();

cssModel.setEffectivePropertyValueForNode(node.id, animationPrefix + 'duration', duration + 'ms');

cssModel.setEffectivePropertyValueForNode(node.id, animationPrefix + 'delay', delay + 'ms');

}