Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 if (targetNode.isShadowRoot() || targetNode.ancestorUserAgentShadowRoot()) 229 if (targetNode.isShadowRoot() || targetNode.ancestorUserAgentShadowRoot())
230 return false; 230 return false;
231 231
232 if (!this._clipboardNodeData) 232 if (!this._clipboardNodeData)
233 return false; 233 return false;
234 234
235 var node = this._clipboardNodeData.node; 235 var node = this._clipboardNodeData.node;
236 if (this._clipboardNodeData.isCut && (node === targetNode || node.isAncestor (targetNode))) 236 if (this._clipboardNodeData.isCut && (node === targetNode || node.isAncestor (targetNode)))
237 return false; 237 return false;
238 238
239 if (targetNode.target() !== node.target()) 239 if (targetNode.domModel() !== node.domModel())
240 return false; 240 return false;
241 return true; 241 return true;
242 } 242 }
243 243
244 /** 244 /**
245 * @param {!SDK.DOMNode} targetNode 245 * @param {!SDK.DOMNode} targetNode
246 */ 246 */
247 pasteNode(targetNode) { 247 pasteNode(targetNode) {
248 if (this.canPaste(targetNode)) 248 if (this.canPaste(targetNode))
249 this._performPaste(targetNode); 249 this._performPaste(targetNode);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 if (!link) 531 if (!link)
532 return null; 532 return null;
533 533
534 return { 534 return {
535 box: link.boxInWindow(), 535 box: link.boxInWindow(),
536 show: async popover => { 536 show: async popover => {
537 var listItem = link.enclosingNodeOrSelfWithNodeName('li'); 537 var listItem = link.enclosingNodeOrSelfWithNodeName('li');
538 var node = /** @type {!Elements.ElementsTreeElement} */ (listItem.treeEl ement).node(); 538 var node = /** @type {!Elements.ElementsTreeElement} */ (listItem.treeEl ement).node();
539 var precomputedFeatures = await this._loadDimensionsForNode(node); 539 var precomputedFeatures = await this._loadDimensionsForNode(node);
540 var preview = await Components.DOMPresentationUtils.buildImagePreviewCon tents( 540 var preview = await Components.DOMPresentationUtils.buildImagePreviewCon tents(
541 node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, precomputedFeatures); 541 node.domModel().target(), link[Elements.ElementsTreeElement.HrefSymb ol], true, precomputedFeatures);
542 if (preview) 542 if (preview)
543 popover.contentElement.appendChild(preview); 543 popover.contentElement.appendChild(preview);
544 return !!preview; 544 return !!preview;
545 } 545 }
546 }; 546 };
547 } 547 }
548 548
549 /** 549 /**
550 * @param {!SDK.DOMNode} node 550 * @param {!SDK.DOMNode} node
551 * @return {!Promise<!Object|undefined>} 551 * @return {!Promise<!Object|undefined>}
(...skipping 1123 matching lines...) Expand 10 before | Expand all | Expand 10 after
1675 */ 1675 */
1676 function resolved(node) { 1676 function resolved(node) {
1677 if (node) { 1677 if (node) {
1678 this.treeOutline._selectedDOMNode = node; 1678 this.treeOutline._selectedDOMNode = node;
1679 this.treeOutline._selectedNodeChanged(); 1679 this.treeOutline._selectedNodeChanged();
1680 } 1680 }
1681 } 1681 }
1682 return true; 1682 return true;
1683 } 1683 }
1684 }; 1684 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698