Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 _setBreakpoint(node, type, enabled) { 164 _setBreakpoint(node, type, enabled) {
165 var breakpointId = this._createBreakpointId(node.id, type); 165 var breakpointId = this._createBreakpointId(node.id, type);
166 var breakpointElement = this._breakpointElements.get(breakpointId); 166 var breakpointElement = this._breakpointElements.get(breakpointId);
167 if (!breakpointElement) { 167 if (!breakpointElement) {
168 breakpointElement = this._createBreakpointElement(node, type, enabled); 168 breakpointElement = this._createBreakpointElement(node, type, enabled);
169 this._breakpointElements.set(breakpointId, breakpointElement); 169 this._breakpointElements.set(breakpointId, breakpointElement);
170 } else { 170 } else {
171 breakpointElement._checkboxElement.checked = enabled; 171 breakpointElement._checkboxElement.checked = enabled;
172 } 172 }
173 if (enabled) 173 if (enabled)
174 node.target().domdebuggerAgent().setDOMBreakpoint(node.id, type); 174 node.domModel().target().domdebuggerAgent().setDOMBreakpoint(node.id, type );
175 node.setMarker(Components.DOMBreakpointsSidebarPane.Marker, true); 175 node.setMarker(Components.DOMBreakpointsSidebarPane.Marker, true);
176 } 176 }
177 177
178 /** 178 /**
179 * @param {!SDK.DOMNode} node 179 * @param {!SDK.DOMNode} node
180 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type 180 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type
181 * @param {boolean} enabled 181 * @param {boolean} enabled
182 */ 182 */
183 _createBreakpointElement(node, type, enabled) { 183 _createBreakpointElement(node, type, enabled) {
184 var element = createElement('li'); 184 var element = createElement('li');
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 */ 226 */
227 _removeBreakpoint(node, type) { 227 _removeBreakpoint(node, type) {
228 var breakpointId = this._createBreakpointId(node.id, type); 228 var breakpointId = this._createBreakpointId(node.id, type);
229 var element = this._breakpointElements.get(breakpointId); 229 var element = this._breakpointElements.get(breakpointId);
230 if (!element) 230 if (!element)
231 return; 231 return;
232 232
233 this.removeListElement(element); 233 this.removeListElement(element);
234 this._breakpointElements.delete(breakpointId); 234 this._breakpointElements.delete(breakpointId);
235 if (element._checkboxElement.checked) 235 if (element._checkboxElement.checked)
236 node.target().domdebuggerAgent().removeDOMBreakpoint(node.id, type); 236 node.domModel().target().domdebuggerAgent().removeDOMBreakpoint(node.id, t ype);
237 node.setMarker(Components.DOMBreakpointsSidebarPane.Marker, this.hasBreakpoi nts(node) ? true : null); 237 node.setMarker(Components.DOMBreakpointsSidebarPane.Marker, this.hasBreakpoi nts(node) ? true : null);
238 } 238 }
239 239
240 /** 240 /**
241 * @param {!SDK.DOMNode} node 241 * @param {!SDK.DOMNode} node
242 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type 242 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type
243 * @param {!Event} event 243 * @param {!Event} event
244 */ 244 */
245 _contextMenu(node, type, event) { 245 _contextMenu(node, type, event) {
246 var contextMenu = new UI.ContextMenu(event); 246 var contextMenu = new UI.ContextMenu(event);
(...skipping 11 matching lines...) Expand all
258 contextMenu.show(); 258 contextMenu.show();
259 } 259 }
260 260
261 /** 261 /**
262 * @param {!SDK.DOMNode} node 262 * @param {!SDK.DOMNode} node
263 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type 263 * @param {!Protocol.DOMDebugger.DOMBreakpointType} type
264 * @param {!Event} event 264 * @param {!Event} event
265 */ 265 */
266 _checkboxClicked(node, type, event) { 266 _checkboxClicked(node, type, event) {
267 if (event.target.checked) 267 if (event.target.checked)
268 node.target().domdebuggerAgent().setDOMBreakpoint(node.id, type); 268 node.domModel().target().domdebuggerAgent().setDOMBreakpoint(node.id, type );
269 else 269 else
270 node.target().domdebuggerAgent().removeDOMBreakpoint(node.id, type); 270 node.domModel().target().domdebuggerAgent().removeDOMBreakpoint(node.id, t ype);
271 this._saveBreakpoints(); 271 this._saveBreakpoints();
272 } 272 }
273 273
274 /** 274 /**
275 * @override 275 * @override
276 * @param {?Object} object 276 * @param {?Object} object
277 */ 277 */
278 flavorChanged(object) { 278 flavorChanged(object) {
279 this._update(); 279 this._update();
280 } 280 }
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 var pane = Components.domBreakpointsSidebarPane; 404 var pane = Components.domBreakpointsSidebarPane;
405 if (pane.element.parentNode !== this.element) 405 if (pane.element.parentNode !== this.element)
406 pane.show(this.element); 406 pane.show(this.element);
407 } 407 }
408 }; 408 };
409 409
410 /** 410 /**
411 * @type {!Components.DOMBreakpointsSidebarPane} 411 * @type {!Components.DOMBreakpointsSidebarPane}
412 */ 412 */
413 Components.domBreakpointsSidebarPane; 413 Components.domBreakpointsSidebarPane;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698