Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2778243002: Add createKernelResolutionEnqueuerListener to kernel/closed_world_test (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add createKernelResolutionEnqueuerListener to kernel/closed_world_test This adds the yet unfinished createKernelResolutionEnqueuerListener method to kernel/closed_world_test for easier tracking of the progress towards computing a closed world purely from Kernel. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/94c8892162f326dee4d56792d161058ce4ee986c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 3 chunks +3 lines, -3 lines 2 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 3 chunks +58 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 14:33:31 UTC) #2
Emily Fortuna
lgtm with comment https://codereview.chromium.org/2778243002/diff/1/pkg/compiler/lib/src/js_backend/resolution_listener.dart File pkg/compiler/lib/src/js_backend/resolution_listener.dart (right): https://codereview.chromium.org/2778243002/diff/1/pkg/compiler/lib/src/js_backend/resolution_listener.dart#newcode217 pkg/compiler/lib/src/js_backend/resolution_listener.dart:217: _kernelTask?.buildKernelIr(); if the option for useKernel ...
3 years, 8 months ago (2017-03-28 18:32:37 UTC) #3
Johnni Winther
https://codereview.chromium.org/2778243002/diff/1/pkg/compiler/lib/src/js_backend/resolution_listener.dart File pkg/compiler/lib/src/js_backend/resolution_listener.dart (right): https://codereview.chromium.org/2778243002/diff/1/pkg/compiler/lib/src/js_backend/resolution_listener.dart#newcode217 pkg/compiler/lib/src/js_backend/resolution_listener.dart:217: _kernelTask?.buildKernelIr(); On 2017/03/28 18:32:36, Emily Fortuna wrote: > if ...
3 years, 8 months ago (2017-03-29 09:07:07 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-03-29 09:26:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94c8892162f326dee4d56792d161058ce4ee986c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698