Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: cc/output/begin_frame_args.cc

Issue 2778223005: Plumb activation time to main (Closed)
Patch Set: remove performance observer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/begin_frame_args.cc
diff --git a/cc/output/begin_frame_args.cc b/cc/output/begin_frame_args.cc
index bf41afa277dafb8600b530df9f9ee7f084db09dd..9809b9b9a839b755c26c950c0355f2db8f9985fe 100644
--- a/cc/output/begin_frame_args.cc
+++ b/cc/output/begin_frame_args.cc
@@ -26,12 +26,16 @@ const char* BeginFrameArgs::TypeToString(BeginFrameArgsType type) {
constexpr uint64_t BeginFrameArgs::kInvalidFrameNumber;
constexpr uint64_t BeginFrameArgs::kStartingFrameNumber;
+BeginFrameArgs::BeginFrameArgs(const BeginFrameArgs& other) = default;
+
BeginFrameArgs::BeginFrameArgs()
: frame_time(base::TimeTicks()),
deadline(base::TimeTicks()),
interval(base::TimeDelta::FromMicroseconds(-1)),
sequence_number(kInvalidFrameNumber),
source_id(0),
+ ready_to_activate_time(base::TimeTicks()),
+ ready_to_activate_source_frame_number(0),
type(BeginFrameArgs::INVALID),
on_critical_path(true) {}
@@ -46,6 +50,9 @@ BeginFrameArgs::BeginFrameArgs(uint32_t source_id,
interval(interval),
sequence_number(sequence_number),
source_id(source_id),
+ // TODO: copy these
+ // ready_to_activate_time(ready_to_activate_time),
+ // ready_to_activate_source_frame_number(ready_to_activate_source_frame_number),
type(type),
on_critical_path(true) {
DCHECK_LE(kStartingFrameNumber, sequence_number);
@@ -91,6 +98,11 @@ void BeginFrameArgs::AsValueInto(base::trace_event::TracedValue* state) const {
state->SetString("created_from", created_from.ToString());
#endif
state->SetBoolean("on_critical_path", on_critical_path);
+ // TODO
+ // state->SetDouble("ready_to_activate_time_us",
+ // ready_to_activate_time.ToInternalValue());
+ // state->SetInteger("ready_to_activate_source_frame_number",
+ // ready_to_activate_source_frame_number);
}
// This is a hard-coded deadline adjustment that assumes 60Hz, to be used in

Powered by Google App Engine
This is Rietveld 408576698