Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: pkg/kernel/testcases/closures/for_loop.dart.expect

Issue 2778223002: Add primitive to create closures and use it for closure conversion (Closed)
Patch Set: Follow common pattern for AST nodes with References in ClosureCreation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/testcases/closures/for_loop.dart.expect
diff --git a/pkg/kernel/testcases/closures/for_loop.dart.expect b/pkg/kernel/testcases/closures/for_loop.dart.expect
index 3a095c15e693aceb86b726e9c2c1da489e95fa1a..56bd3400cea1c3e61316dc3d32cb61b4503739e1 100644
--- a/pkg/kernel/testcases/closures/for_loop.dart.expect
+++ b/pkg/kernel/testcases/closures/for_loop.dart.expect
@@ -2,31 +2,6 @@ library;
import self as self;
import "dart:core" as core;
-class Closure#main#function extends core::Object implements core::Function {
- field core::String note = "This is temporary. The VM doesn't need closure classes.";
- field Vector context;
- constructor •(final Vector context) → dynamic
- : self::Closure#main#function::context = context
- ;
- method call() → dynamic {
- "This is a temporary solution. In the VM, this will become an additional parameter.";
- final Vector #contextParameter = this.{self::Closure#main#function::context};
- return #contextParameter[0][1] = #contextParameter[1];
- }
-}
-class Closure#main#function#1 extends core::Object implements core::Function {
- field core::String note = "This is temporary. The VM doesn't need closure classes.";
- field Vector context;
- constructor •(final Vector context) → dynamic
- : self::Closure#main#function#1::context = context
- ;
- method call() → dynamic {
- "This is a temporary solution. In the VM, this will become an additional parameter.";
- final Vector #contextParameter = this.{self::Closure#main#function#1::context};
- if(!(#contextParameter[0][1]).==(self::max.-(1)))
- throw "last: ${#contextParameter[0][1]} != ${self::max.-(1)}";
- }
-}
static const field core::int max = 100;
static method main() → dynamic {
dynamic closures = <dynamic>[];
@@ -38,8 +13,8 @@ static method main() → dynamic {
#context[0] = #context;
#context[1] = 0;
for (; (#context[1]).<(self::max); #context = CopyVector(#context), #context[1] = (#context[1]).+(1)) {
- closures.add(new self::Closure#main#function::•(#context));
- closures2.add(new self::Closure#main#function#1::•(#context));
+ closures.add(MakeClosure<() → dynamic>(self::closure#main#function, #context));
+ closures2.add(MakeClosure<() → dynamic>(self::closure#main#function#1, #context));
}
}
core::int sum = 0;
@@ -54,3 +29,10 @@ static method main() → dynamic {
throw core::Exception::•("Unexpected sum = ${sum} != ${expectedSum}");
}
}
+static method closure#main#function(Vector #contextParameter) → dynamic {
+ return #contextParameter[0][1] = #contextParameter[1];
+}
+static method closure#main#function#1(Vector #contextParameter) → dynamic {
+ if(!(#contextParameter[0][1]).==(self::max.-(1)))
+ throw "last: ${#contextParameter[0][1]} != ${self::max.-(1)}";
+}

Powered by Google App Engine
This is Rietveld 408576698