Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2778213002: Use message.yaml in parser. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add helper methods to parser. #

Patch Set 3 : Use helper methods. #

Patch Set 4 : Fix NPE in serialization tests. #

Total comments: 2

Patch Set 5 : Address comments. #

Patch Set 6 : Update subpackage relationships. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1529 lines, -1112 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 3 9 chunks +62 lines, -116 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 2 chunks +5 lines, -7 lines 0 comments Download
A pkg/front_end/lib/src/fasta/fasta_codes.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 1 chunk +913 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 3 4 5 2 chunks +12 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/front_end/lib/src/fasta/parser/error_kind.dart View 1 chunk +0 lines, -63 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 62 chunks +245 lines, -161 lines 0 comments Download
D pkg/front_end/lib/src/fasta/problems.dart View 1 chunk +0 lines, -592 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 9 chunks +27 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 2 chunks +43 lines, -47 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/scanner/errors.dart View 2 chunks +16 lines, -11 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 2 3 4 16 chunks +65 lines, -2 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 5 chunks +51 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 8 months ago (2017-03-28 14:12:12 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2778213002/diff/60001/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2778213002/diff/60001/pkg/front_end/messages.yaml#newcode15 pkg/front_end/messages.yaml:15: # In addition, an entry can contain an ...
3 years, 8 months ago (2017-03-29 08:28:10 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2778213002/diff/60001/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2778213002/diff/60001/pkg/front_end/messages.yaml#newcode15 pkg/front_end/messages.yaml:15: # In addition, an entry can ...
3 years, 8 months ago (2017-03-29 08:55:24 UTC) #4
ahe
3 years, 8 months ago (2017-03-29 09:02:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
a62c5631bfbe2a33ead084674199d736044742e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698