android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java - Issue 2778203003: WebView: Create UMA uploader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

Issue 2778203003: WebView: Create UMA uploader (Closed)

Patch Set: WebView: Create UMA uploader Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java ('k') | android_webview/native/BUILD.gn » ('j') | android_webview/native/aw_metrics_log_uploader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java b/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

index 038e6ea2ed331057084c4370b62956afe1e44a48..731050c56fda9601a71057b23cb503fd82daa4cd 100644

--- a/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

@@ -68,4 +68,7 @@ public class PlatformServiceBridge {

ThreadUtils.assertOnUiThread();

callback.onReceiveValue(false);

}

+ // Takes an uncompressed, serialized UMA proto.

Alexei Svitkine (slow) 2017/03/29 19:19:17 Nit: Add a sentence at the beginning to explain wh

paulmiller 2017/03/29 19:52:38 I added a bit. This whole class is vague by design

+ public void logMetrics(byte[] data) {}

}