Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3576)

Unified Diff: base/command_line_unittest.cc

Issue 2778173003: base: Support command line wrappers with quoted arguments (Closed)
Patch Set: Review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/command_line.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line_unittest.cc
diff --git a/base/command_line_unittest.cc b/base/command_line_unittest.cc
index bcfc6c59c916a2e7964c057e918b596b25ec9eff..79c9aecc2a24e933bf7688fe12fa302db6adcfe4 100644
--- a/base/command_line_unittest.cc
+++ b/base/command_line_unittest.cc
@@ -406,4 +406,35 @@ TEST(CommandLineTest, Copy) {
EXPECT_TRUE(assigned.HasSwitch(pair.first));
}
+TEST(CommandLineTest, PrependSimpleWrapper) {
+ CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
+ cl.AppendSwitch("a");
+ cl.AppendSwitch("b");
+ cl.PrependWrapper(FILE_PATH_LITERAL("wrapper --foo --bar"));
+
+ EXPECT_EQ(6u, cl.argv().size());
+ EXPECT_EQ(FILE_PATH_LITERAL("wrapper"), cl.argv()[0]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--foo"), cl.argv()[1]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--bar"), cl.argv()[2]);
+ EXPECT_EQ(FILE_PATH_LITERAL("Program"), cl.argv()[3]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--a"), cl.argv()[4]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--b"), cl.argv()[5]);
+}
+
+TEST(CommandLineTest, PrependComplexWrapper) {
+ CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
+ cl.AppendSwitch("a");
+ cl.AppendSwitch("b");
+ cl.PrependWrapper(
+ FILE_PATH_LITERAL("wrapper --foo='hello world' --bar=\"let's go\""));
+
+ EXPECT_EQ(6u, cl.argv().size());
+ EXPECT_EQ(FILE_PATH_LITERAL("wrapper"), cl.argv()[0]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--foo='hello world'"), cl.argv()[1]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--bar=\"let's go\""), cl.argv()[2]);
+ EXPECT_EQ(FILE_PATH_LITERAL("Program"), cl.argv()[3]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--a"), cl.argv()[4]);
+ EXPECT_EQ(FILE_PATH_LITERAL("--b"), cl.argv()[5]);
+}
+
} // namespace base
« no previous file with comments | « base/command_line.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698