Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2778123003: [scheduler] Add WakeupBudgetPool. (Closed)
Patch Set: Second iteration. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index 5f38fbddbd4fca2ab22aa9150331baa1975713dc..35a8d4f231948268523083af6a90b3d54ef32149 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -224,7 +224,8 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
in_idle_period_for_testing(false),
use_virtual_time(false),
is_audio_playing(false),
- rail_mode_observer(nullptr) {
+ rail_mode_observer(nullptr),
+ wake_up_budget_pool(nullptr) {
foreground_main_thread_load_tracker.Resume(now);
}
@@ -338,6 +339,7 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::NewLoadingTaskQueue(
}
loading_task_queue->AddTaskObserver(
&GetMainThreadOnly().loading_task_cost_estimator);
+ AddQueueToWakeUpBudgetPool(loading_task_queue.get());
return loading_task_queue;
}
@@ -364,6 +366,7 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::NewTimerTaskQueue(
}
timer_task_queue->AddTaskObserver(
&GetMainThreadOnly().timer_task_cost_estimator);
+ AddQueueToWakeUpBudgetPool(timer_task_queue.get());
return timer_task_queue;
}
@@ -1357,6 +1360,10 @@ IdleTimeEstimator* RendererSchedulerImpl::GetIdleTimeEstimatorForTesting() {
return &GetMainThreadOnly().idle_time_estimator;
}
+WakeUpBudgetPool* RendererSchedulerImpl::GetWakeUpBudgetPoolForTesting() {
+ return GetMainThreadOnly().wake_up_budget_pool;
+}
+
void RendererSchedulerImpl::SuspendTimerQueue() {
GetMainThreadOnly().timer_queue_suspend_count++;
ForceUpdatePolicy();
@@ -1888,6 +1895,18 @@ bool RendererSchedulerImpl::ShouldDisableThrottlingBecauseOfAudio(
now;
}
+void RendererSchedulerImpl::AddQueueToWakeUpBudgetPool(TaskQueue* queue) {
+ if (!GetMainThreadOnly().wake_up_budget_pool) {
+ GetMainThreadOnly().wake_up_budget_pool =
+ task_queue_throttler()->CreateWakeUpBudgetPool("renderer-wake-up-pool");
alex clarke (OOO till 29th) 2017/04/26 13:31:55 I wonder if we should use a builder for WakeUpBudg
altimin 2017/04/26 14:31:29 I'd like to have an ability to change wakeup rate
+ GetMainThreadOnly().wake_up_budget_pool->SetWakeUpRate(1);
+ GetMainThreadOnly().wake_up_budget_pool->SetWakeUpDuration(
+ base::TimeDelta());
+ }
+ GetMainThreadOnly().wake_up_budget_pool->AddQueue(tick_clock()->NowTicks(),
+ queue);
+}
+
TimeDomain* RendererSchedulerImpl::GetActiveTimeDomain() {
if (GetMainThreadOnly().use_virtual_time) {
return GetVirtualTimeDomain();

Powered by Google App Engine
This is Rietveld 408576698