Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2778123003: [scheduler] Add WakeupBudgetPool. (Closed)
Patch Set: Rebased & addressed comments from skyostil@ and alexclarke@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index d7db5c181d72fc60ada9f14321dada6b1694cf49..ac6e5982510d3a75279362848cf48ffc177bd915 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -217,7 +217,8 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
in_idle_period_for_testing(false),
use_virtual_time(false),
is_audio_playing(false),
- rail_mode_observer(nullptr) {
+ rail_mode_observer(nullptr),
+ wake_up_budget_pool(nullptr) {
foreground_main_thread_load_tracker.Resume(now);
}
@@ -331,6 +332,7 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::NewLoadingTaskQueue(
}
loading_task_queue->AddTaskObserver(
&GetMainThreadOnly().loading_task_cost_estimator);
+ AddQueueToWakeUpBudgetPool(loading_task_queue.get());
return loading_task_queue;
}
@@ -357,6 +359,7 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::NewTimerTaskQueue(
}
timer_task_queue->AddTaskObserver(
&GetMainThreadOnly().timer_task_cost_estimator);
+ AddQueueToWakeUpBudgetPool(timer_task_queue.get());
return timer_task_queue;
}
@@ -1349,6 +1352,10 @@ IdleTimeEstimator* RendererSchedulerImpl::GetIdleTimeEstimatorForTesting() {
return &GetMainThreadOnly().idle_time_estimator;
}
+WakeUpBudgetPool* RendererSchedulerImpl::GetWakeUpBudgetPoolForTesting() {
+ return GetMainThreadOnly().wake_up_budget_pool;
+}
+
void RendererSchedulerImpl::SuspendTimerQueue() {
GetMainThreadOnly().timer_queue_suspend_count++;
ForceUpdatePolicy();
@@ -1878,6 +1885,18 @@ bool RendererSchedulerImpl::ShouldDisableThrottlingBecauseOfAudio(
now;
}
+void RendererSchedulerImpl::AddQueueToWakeUpBudgetPool(TaskQueue* queue) {
+ if (!GetMainThreadOnly().wake_up_budget_pool) {
+ GetMainThreadOnly().wake_up_budget_pool =
+ task_queue_throttler()->CreateWakeUpBudgetPool("renderer-wake-up-pool");
Sami 2017/05/03 16:53:05 uber-nit: let's use underscores instead of hyphens
altimin 2017/05/04 10:50:06 Done.
+ GetMainThreadOnly().wake_up_budget_pool->SetWakeUpRate(1);
+ GetMainThreadOnly().wake_up_budget_pool->SetWakeUpDuration(
+ base::TimeDelta());
+ }
+ GetMainThreadOnly().wake_up_budget_pool->AddQueue(tick_clock()->NowTicks(),
+ queue);
+}
+
TimeDomain* RendererSchedulerImpl::GetActiveTimeDomain() {
if (GetMainThreadOnly().use_virtual_time) {
return GetVirtualTimeDomain();

Powered by Google App Engine
This is Rietveld 408576698