Alternative: Convert Chrome NativeLibraryTestBase tests example

chrome/android/javatests/src/org/chromium/chrome/browser/IntentHandlerTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
+import static org.chromium.content.browser.test.NativeLibraryTestRule.NativeLibraryInitializationOption.INIT_BROWSER_PROCESS;
+
 import android.content.Context;
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.SystemClock;
 import android.provider.Browser;
 import android.speech.RecognizerResultsIntent;
+import android.support.test.InstrumentationRegistry;
+import android.support.test.annotation.UiThreadTest;
 import android.support.test.filters.MediumTest;
 import android.support.test.filters.SmallTest;
-import android.test.UiThreadTest;
+import android.support.test.rule.UiThreadTestRule;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.RuleChain;
+import org.junit.runner.RunWith;
 
 import org.chromium.base.CollectionUtil;
-import org.chromium.base.CommandLine;
+import org.chromium.base.test.BaseJUnit4ClassRunner;
 import org.chromium.base.test.util.Feature;
-import org.chromium.content.browser.test.NativeLibraryTestBase;
+import org.chromium.content.browser.test.NativeLibraryTestRule;
 
 import java.util.Vector;
 
 /**
  * Tests for IntentHandler.
  * TODO(nileshagrawal): Add tests for onNewIntent.
  */
-public class IntentHandlerTest extends NativeLibraryTestBase {
+@RunWith(BaseJUnit4ClassRunner.class)
+public class IntentHandlerTest {
+    @Rule
+    public RuleChain mAllRules =
+            RuleChain.outerRule(new ChromeTestCommandLineInitRule().shouldSetUp(true))
+                    .around(new NativeLibraryTestRule()
+                                    .setInitOption(INIT_BROWSER_PROCESS)
+                                    .shouldSetUp(true))
+                    .around(new UiThreadTestRule());
+
     private static final String VOICE_SEARCH_QUERY = "VOICE_QUERY";
     private static final String VOICE_SEARCH_QUERY_URL = "http://www.google.com/?q=VOICE_QUERY";
 
     private static final String VOICE_URL_QUERY = "www.google.com";
     private static final String VOICE_URL_QUERY_URL = "INVALID_URLZ";
 
     private static final String[] ACCEPTED_INTENT_URLS = {"http://www.google.com",
             "http://movies.nytimes.com/movie/review?"
                     + "res=9405EFDB1E3BE23BBC4153DFB7678382659EDE&partner=Rotten Tomatoes",
             "chrome://newtab", "file://foo.txt", "ftp://www.foo.com", "https://www.gmail.com", "",
@@ skipping 36 matching lines @@
 
     private void processUrls(String[] urls, boolean isValid) {
         Vector<String> failedTests = new Vector<String>();
 
         for (String url : urls) {
             mIntent.setData(Uri.parse(url));
             if (mIntentHandler.intentHasValidUrl(mIntent) != isValid) {
                 failedTests.add(url);
             }
         }
-        assertTrue(failedTests.toString(), failedTests.isEmpty());
+        Assert.assertTrue(failedTests.toString(), failedTests.isEmpty());
     }
 
-    @Override
+    @Before
     public void setUp() throws Exception {
-        super.setUp();
-
-        CommandLine.init(null);
-        loadNativeLibraryAndInitBrowserProcess();
         IntentHandler.setTestIntentsEnabled(false);
         mIntentHandler = new IntentHandler(null, null);
         mIntent = new Intent();
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testAcceptedUrls() {
         processUrls(ACCEPTED_INTENT_URLS, true);
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRejectedUrls() {
         processUrls(REJECTED_INTENT_URLS, false);
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testAcceptedGoogleChromeSchemeNavigateUrls() {
         // Test all of the accepted URLs after prepending googlechrome://navigate?url.
         String[] expectedAccepts = new String[ACCEPTED_INTENT_URLS.length];
         for (int i = 0; i < ACCEPTED_INTENT_URLS.length; ++i) {
             expectedAccepts[i] =
                     IntentHandler.GOOGLECHROME_NAVIGATE_PREFIX + ACCEPTED_INTENT_URLS[i];
         }
         processUrls(expectedAccepts, true);
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRejectedGoogleChromeSchemeNavigateUrls() {
         // Test all of the rejected URLs after prepending googlechrome://navigate?url.
         String[] expectedRejections = new String[REJECTED_INTENT_URLS.length];
         for (int i = 0; i < REJECTED_INTENT_URLS.length; ++i) {
             expectedRejections[i] =
                     IntentHandler.GOOGLECHROME_NAVIGATE_PREFIX + REJECTED_INTENT_URLS[i];
         }
         processUrls(expectedRejections, false);
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRejectedGoogleChromeSchemeUrls() {
         Vector<String> failedTests = new Vector<String>();
 
         for (String url : REJECTED_GOOGLECHROME_URLS) {
             mIntent.setData(Uri.parse(url));
             if (IntentHandler.getUrlFromIntent(mIntent) != null) {
                 failedTests.add(url);
             }
         }
-        assertTrue(failedTests.toString(), failedTests.isEmpty());
+        Assert.assertTrue(failedTests.toString(), failedTests.isEmpty());
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testNullUrlIntent() {
         mIntent.setData(null);
-        assertTrue(
+        Assert.assertTrue(
                 "Intent with null data should be valid", mIntentHandler.intentHasValidUrl(mIntent));
     }
 
+    @Test
     @UiThreadTest
     @MediumTest
     @Feature({"Android-AppBase"})
     public void testGetQueryFromVoiceSearchResultIntent_validVoiceQuery() {
         Intent intent = new Intent(RecognizerResultsIntent.ACTION_VOICE_SEARCH_RESULTS);
         intent.putStringArrayListExtra(RecognizerResultsIntent.EXTRA_VOICE_SEARCH_RESULT_STRINGS,
                 CollectionUtil.newArrayList(VOICE_SEARCH_QUERY));
         intent.putStringArrayListExtra(RecognizerResultsIntent.EXTRA_VOICE_SEARCH_RESULT_URLS,
                 CollectionUtil.newArrayList(VOICE_SEARCH_QUERY_URL));
         String query = IntentHandler.getUrlFromVoiceSearchResult(intent);
-        assertEquals(VOICE_SEARCH_QUERY_URL, query);
+        Assert.assertEquals(VOICE_SEARCH_QUERY_URL, query);
     }
 
+    @Test
     @UiThreadTest
     @MediumTest
     @Feature({"Android-AppBase"})
     public void testGetQueryFromVoiceSearchResultIntent_validUrlQuery() {
         Intent intent = new Intent(RecognizerResultsIntent.ACTION_VOICE_SEARCH_RESULTS);
         intent.putStringArrayListExtra(RecognizerResultsIntent.EXTRA_VOICE_SEARCH_RESULT_STRINGS,
                 CollectionUtil.newArrayList(VOICE_URL_QUERY));
         intent.putStringArrayListExtra(RecognizerResultsIntent.EXTRA_VOICE_SEARCH_RESULT_URLS,
                 CollectionUtil.newArrayList(VOICE_URL_QUERY_URL));
         String query = IntentHandler.getUrlFromVoiceSearchResult(intent);
-        assertTrue(String.format("Expected qualified URL: %s, to start "
-                                   + "with http://www.google.com",
-                           query),
+        Assert.assertTrue(String.format("Expected qualified URL: %s, to start "
+                                          + "with http://www.google.com",
+                                  query),
                 query.indexOf("http://www.google.com") == 0);
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraReferrer() {
         // Check that EXTRA_REFERRER is not accepted with a random URL.
         Intent foreignIntent = new Intent(Intent.ACTION_VIEW);
         foreignIntent.putExtra(Intent.EXTRA_REFERRER, GOOGLE_URL);
-        assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(foreignIntent));
+        Assert.assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(foreignIntent));
 
         // Check that EXTRA_REFERRER with android-app URL works.
         final String appUrl = "android-app://com.application/http/www.application.com";
         Intent appIntent = new Intent(Intent.ACTION_VIEW);
         appIntent.putExtra(Intent.EXTRA_REFERRER, Uri.parse(appUrl));
-        assertEquals(appUrl, IntentHandler.getReferrerUrlIncludingExtraHeaders(appIntent));
+        Assert.assertEquals(appUrl, IntentHandler.getReferrerUrlIncludingExtraHeaders(appIntent));
 
         // Check that EXTRA_REFERRER_NAME with android-app works.
         Intent nameIntent = new Intent(Intent.ACTION_VIEW);
         nameIntent.putExtra(Intent.EXTRA_REFERRER_NAME, appUrl);
-        assertEquals(appUrl, IntentHandler.getReferrerUrlIncludingExtraHeaders(nameIntent));
+        Assert.assertEquals(appUrl, IntentHandler.getReferrerUrlIncludingExtraHeaders(nameIntent));
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraHeadersInclReferer() {
         // Check that invalid header specified in EXTRA_HEADERS isn't used.
         Bundle bundle = new Bundle();
         bundle.putString("X-custom-header", "X-custom-value");
         bundle.putString("Referer", GOOGLE_URL);
         Intent headersIntent = new Intent(Intent.ACTION_VIEW);
         headersIntent.putExtra(Browser.EXTRA_HEADERS, bundle);
-        assertEquals("X-custom-header: X-custom-value",
+        Assert.assertEquals("X-custom-header: X-custom-value",
                 IntentHandler.getExtraHeadersFromIntent(headersIntent));
-        assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
+        Assert.assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraHeadersInclRefererMultiple() {
         // Check that invalid header specified in EXTRA_HEADERS isn't used.
         Bundle bundle = new Bundle();
         bundle.putString("X-custom-header", "X-custom-value");
         bundle.putString("X-custom-header-2", "X-custom-value-2");
         bundle.putString("Referer", GOOGLE_URL);
         Intent headersIntent = new Intent(Intent.ACTION_VIEW);
         headersIntent.putExtra(Browser.EXTRA_HEADERS, bundle);
-        assertEquals("X-custom-header-2: X-custom-value-2\nX-custom-header: X-custom-value",
+        Assert.assertEquals("X-custom-header-2: X-custom-value-2\nX-custom-header: X-custom-value",
                 IntentHandler.getExtraHeadersFromIntent(headersIntent));
-        assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
+        Assert.assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraHeadersOnlyReferer() {
         // Check that invalid header specified in EXTRA_HEADERS isn't used.
         Bundle bundle = new Bundle();
         bundle.putString("Referer", GOOGLE_URL);
         Intent headersIntent = new Intent(Intent.ACTION_VIEW);
         headersIntent.putExtra(Browser.EXTRA_HEADERS, bundle);
-        assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
+        Assert.assertNull(IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraHeadersAndExtraReferrer() {
         String validReferer = "android-app://package/http/url";
         Bundle bundle = new Bundle();
         bundle.putString("Referer", GOOGLE_URL);
         Intent headersIntent = new Intent(Intent.ACTION_VIEW);
         headersIntent.putExtra(Browser.EXTRA_HEADERS, bundle);
         headersIntent.putExtra(Intent.EXTRA_REFERRER, Uri.parse(validReferer));
-        assertEquals(validReferer,
-                IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
-        assertNull(IntentHandler.getExtraHeadersFromIntent(headersIntent));
+        Assert.assertEquals(
+                validReferer, IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
+        Assert.assertNull(IntentHandler.getExtraHeadersFromIntent(headersIntent));
     }
 
+    @Test
     @UiThreadTest
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testRefererUrl_extraHeadersValidReferrer() {
         String validReferer = "android-app://package/http/url";
         Bundle bundle = new Bundle();
         bundle.putString("Referer", validReferer);
         Intent headersIntent = new Intent(Intent.ACTION_VIEW);
         headersIntent.putExtra(Browser.EXTRA_HEADERS, bundle);
-        assertEquals(validReferer,
-                IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
-        assertNull(IntentHandler.getExtraHeadersFromIntent(headersIntent));
+        Assert.assertEquals(
+                validReferer, IntentHandler.getReferrerUrlIncludingExtraHeaders(headersIntent));
+        Assert.assertNull(IntentHandler.getExtraHeadersFromIntent(headersIntent));
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testAddTimestampToIntent() {
         Intent intent = new Intent();
-        assertEquals(-1, IntentHandler.getTimestampFromIntent(intent));
+        Assert.assertEquals(-1, IntentHandler.getTimestampFromIntent(intent));
         // Check both before and after to make sure that the returned value is
         // really from {@link SystemClock#elapsedRealtime()}.
         long before = SystemClock.elapsedRealtime();
         IntentHandler.addTimestampToIntent(intent);
         long after = SystemClock.elapsedRealtime();
-        assertTrue("Time should be increasing",
+        Assert.assertTrue("Time should be increasing",
                 before <= IntentHandler.getTimestampFromIntent(intent));
-        assertTrue("Time should be increasing",
-                IntentHandler.getTimestampFromIntent(intent) <= after);
+        Assert.assertTrue(
+                "Time should be increasing", IntentHandler.getTimestampFromIntent(intent) <= after);
     }
 
+    @Test
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testGeneratedReferrer() {
-        Context context = getInstrumentation().getTargetContext();
+        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
         String packageName = context.getPackageName();
         String referrer = IntentHandler.constructValidReferrerForAuthority(packageName).getUrl();
-        assertEquals("android-app://" + packageName, referrer);
+        Assert.assertEquals("android-app://" + packageName, referrer);
     }
 }