Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: ios/chrome/browser/ui/authentication/signin_promo_view.mm

Issue 2778073002: Adding VisualConstraintsWithMetricsAndOptions() (Closed)
Patch Set: Merge + fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/uikit_ui_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h" 5 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h" 8 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
9 #import "ios/chrome/browser/ui/uikit_ui_util.h" 9 #import "ios/chrome/browser/ui/uikit_ui_util.h"
10 #include "ios/chrome/grit/ios_chromium_strings.h" 10 #include "ios/chrome/grit/ios_chromium_strings.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 "kVerticalPaddingkButtonVerticalPadding-[" 110 "kVerticalPaddingkButtonVerticalPadding-["
111 "primaryButton(kButtonHeight)]"; 111 "primaryButton(kButtonHeight)]";
112 NSArray* visualConstraints = @[ 112 NSArray* visualConstraints = @[
113 formatString, 113 formatString,
114 @"H:|-kHorizontalPadding-[primaryButton]-kHorizontalPadding-|" 114 @"H:|-kHorizontalPadding-[primaryButton]-kHorizontalPadding-|"
115 ]; 115 ];
116 ApplyVisualConstraintsWithMetricsAndOptions( 116 ApplyVisualConstraintsWithMetricsAndOptions(
117 visualConstraints, views, metrics, NSLayoutFormatAlignAllCenterX); 117 visualConstraints, views, metrics, NSLayoutFormatAlignAllCenterX);
118 118
119 // Constraints for cold state mode. 119 // Constraints for cold state mode.
120 NSMutableArray* constraints = [NSMutableArray array]; 120 NSArray* coldStateVisualConstraints = @[
121 NSString* primaryButtonVerticalConstraint = 121 @"V:[primaryButton]-kVerticalPaddingkButtonVerticalPadding-|",
122 @"V:[primaryButton]-kVerticalPaddingkButtonVerticalPadding-|"; 122 @"V:[imageView(kChromeImageFixedSize)]",
123 [constraints addObjectsFromArray:[NSLayoutConstraint 123 ];
124 constraintsWithVisualFormat: 124 _coldStateConstraints = VisualConstraintsWithMetrics(
125 primaryButtonVerticalConstraint 125 coldStateVisualConstraints, views, metrics);
126 options:0
127 metrics:metrics
128 views:views]];
129 // Remove this rule once chrome image is added.
130 NSString* imageViewVerticalSizeConstraint =
131 @"V:[imageView(kChromeImageFixedSize)]";
132 [constraints addObjectsFromArray:[NSLayoutConstraint
133 constraintsWithVisualFormat:
134 imageViewVerticalSizeConstraint
135 options:0
136 metrics:metrics
137 views:views]];
138 _coldStateConstraints = [constraints copy];
139 126
140 // Constraints for warm state mode. 127 // Constraints for warm state mode.
141 constraints = [NSMutableArray array]; 128 formatString = @"V:[primaryButton]-kButtonVerticalPaddingx2-["
142 NSString* buttonsVerticalConstraint = 129 "secondaryButton(kButtonHeight)]-"
143 @"V:[primaryButton]-kButtonVerticalPaddingx2-[" 130 "kVerticalPaddingkButtonVerticalPadding-|";
144 "secondaryButton(kButtonHeight)]-" 131 NSArray* warmStateVisualConstraints = @[
145 "kVerticalPaddingkButtonVerticalPadding-|"; 132 formatString,
146 [constraints addObjectsFromArray: 133 @"H:|-kHorizontalPadding-[secondaryButton]-kHorizontalPadding-|",
147 [NSLayoutConstraint 134 ];
148 constraintsWithVisualFormat:buttonsVerticalConstraint 135 _warmStateConstraints = VisualConstraintsWithMetrics(
149 options:0 136 warmStateVisualConstraints, views, metrics);
150 metrics:metrics
151 views:views]];
152 NSString* secondaryButtonHorizontalConstraint =
153 @"H:|-kHorizontalPadding-[secondaryButton]-kHorizontalPadding-|";
154 [constraints addObjectsFromArray:[NSLayoutConstraint
155 constraintsWithVisualFormat:
156 secondaryButtonHorizontalConstraint
157 options:0
158 metrics:metrics
159 views:views]];
160 _warmStateConstraints = [constraints copy];
161 137
162 _mode = SigninPromoViewModeColdState; 138 _mode = SigninPromoViewModeColdState;
163 [self activateColdMode]; 139 [self activateColdMode];
164 } 140 }
165 return self; 141 return self;
166 } 142 }
167 143
168 - (void)setMode:(SigninPromoViewMode)mode { 144 - (void)setMode:(SigninPromoViewMode)mode {
169 if (mode == _mode) { 145 if (mode == _mode) {
170 return; 146 return;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 target:self 213 target:self
238 selector:@selector(accessibilitySecondaryAction:)]; 214 selector:@selector(accessibilitySecondaryAction:)];
239 return @[ primaryCustomAction, secondaryCustomAction ]; 215 return @[ primaryCustomAction, secondaryCustomAction ];
240 } 216 }
241 217
242 - (NSString*)accessibilityLabel { 218 - (NSString*)accessibilityLabel {
243 return _textLabel.text; 219 return _textLabel.text;
244 } 220 }
245 221
246 @end 222 @end
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/ui/uikit_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698