Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

Issue 2778053002: Fetch ARC Kiosk app name and icon from Android side. (Closed)
Patch Set: some nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 .GetImageNamed(IDR_APP_DEFAULT_ICON) 122 .GetImageNamed(IDR_APP_DEFAULT_ICON)
123 .ToSkBitmap()); 123 .ToSkBitmap());
124 } else { 124 } else {
125 icon_url = webui::GetBitmapDataUrl(*app_data.icon.bitmap()); 125 icon_url = webui::GetBitmapDataUrl(*app_data.icon.bitmap());
126 } 126 }
127 app_info->SetString("iconUrl", icon_url); 127 app_info->SetString("iconUrl", icon_url);
128 128
129 apps_list.Append(std::move(app_info)); 129 apps_list.Append(std::move(app_info));
130 } 130 }
131 131
132 const auto& arc_apps = ArcKioskAppManager::Get()->GetAllApps(); 132 ArcKioskAppManager::Apps arc_apps;
133 ArcKioskAppManager::Get()->GetAllApps(&arc_apps);
133 for (size_t i = 0; i < arc_apps.size(); ++i) { 134 for (size_t i = 0; i < arc_apps.size(); ++i) {
134 std::unique_ptr<base::DictionaryValue> app_info( 135 std::unique_ptr<base::DictionaryValue> app_info(
135 new base::DictionaryValue()); 136 new base::DictionaryValue());
136 app_info->SetBoolean("isApp", true); 137 app_info->SetBoolean("isApp", true);
137 app_info->SetBoolean("isAndroidApp", true); 138 app_info->SetBoolean("isAndroidApp", true);
138 app_info->SetString("id", arc_apps[i].app_info().package_name()); 139 app_info->SetString("id", arc_apps[i]->app_id());
139 app_info->SetString("account_email", 140 app_info->SetString("account_email",
140 arc_apps[i].account_id().GetUserEmail()); 141 arc_apps[i]->account_id().GetUserEmail());
141 app_info->SetString("label", arc_apps[i].name()); 142 app_info->SetString("label", arc_apps[i]->name());
142 143
143 std::string icon_url = 144 std::string icon_url;
144 webui::GetBitmapDataUrl(*ResourceBundle::GetSharedInstance() 145 if (arc_apps[i]->icon().isNull()) {
145 .GetImageNamed(IDR_APP_DEFAULT_ICON) 146 icon_url =
146 .ToSkBitmap()); 147 webui::GetBitmapDataUrl(*ResourceBundle::GetSharedInstance()
148 .GetImageNamed(IDR_APP_DEFAULT_ICON)
149 .ToSkBitmap());
150 } else {
151 icon_url = webui::GetBitmapDataUrl(*arc_apps[i]->icon().bitmap());
152 }
147 app_info->SetString("iconUrl", icon_url); 153 app_info->SetString("iconUrl", icon_url);
148 154
149 apps_list.Append(std::move(app_info)); 155 apps_list.Append(std::move(app_info));
150 } 156 }
151 157
152 web_ui()->CallJavascriptFunctionUnsafe( 158 web_ui()->CallJavascriptFunctionUnsafe(
153 EnableNewKioskUI() ? kKioskSetAppsNewAPI : kKioskSetAppsOldAPI, 159 EnableNewKioskUI() ? kKioskSetAppsNewAPI : kKioskSetAppsOldAPI,
154 apps_list); 160 apps_list);
155 } 161 }
156 162
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 void KioskAppMenuHandler::UpdateState(NetworkError::ErrorReason reason) { 204 void KioskAppMenuHandler::UpdateState(NetworkError::ErrorReason reason) {
199 if (network_state_informer_->state() == NetworkStateInformer::ONLINE) 205 if (network_state_informer_->state() == NetworkStateInformer::ONLINE)
200 KioskAppManager::Get()->RetryFailedAppDataFetch(); 206 KioskAppManager::Get()->RetryFailedAppDataFetch();
201 } 207 }
202 208
203 void KioskAppMenuHandler::OnArcKioskAppsChanged() { 209 void KioskAppMenuHandler::OnArcKioskAppsChanged() {
204 SendKioskApps(); 210 SendKioskApps();
205 } 211 }
206 212
207 } // namespace chromeos 213 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698