Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: net/spdy/platform/api/spdy_string_utils_test.cc

Issue 2778043004: Factor out StringAppendF into spdy/platform/. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/platform/api/spdy_string_utils_test.cc
diff --git a/net/spdy/platform/api/spdy_string_utils_test.cc b/net/spdy/platform/api/spdy_string_utils_test.cc
index 89d86a9c76ab79fd201514368cde884d53db9bc9..1a762264152c01b21387baed31205d771cba9535 100644
--- a/net/spdy/platform/api/spdy_string_utils_test.cc
+++ b/net/spdy/platform/api/spdy_string_utils_test.cc
@@ -13,7 +13,7 @@ namespace net {
namespace test {
namespace {
-TEST(SpdyStrUtilsTest, StrCat) {
+TEST(SpdyStrUtilsTest, SpdyStrCat) {
// No arguments.
EXPECT_EQ("", SpdyStrCat());
@@ -70,7 +70,7 @@ TEST(SpdyStrUtilsTest, StrCat) {
SpdyStrCat(d, t, t, string_bar, i, u, kBar, t, d, f));
}
-TEST(SpdyStrUtilsTest, StrAppend) {
+TEST(SpdyStrUtilsTest, SpdyStrAppend) {
// No arguments on empty string.
std::string output;
SpdyStrAppend(&output);
@@ -165,13 +165,29 @@ TEST(SpdyStrUtilsTest, StrAppend) {
EXPECT_EQ("foo1foo081bar3.141513.141511bar18bar13.14150", output);
}
-TEST(SpdyStrUtilsTest, StringPrintf) {
+TEST(SpdyStrUtilsTest, SpdyStringPrintf) {
EXPECT_EQ("", SpdyStringPrintf("%s", ""));
EXPECT_EQ("foobar", SpdyStringPrintf("%sbar", "foo"));
EXPECT_EQ("foobar", SpdyStringPrintf("%s%s", "foo", "bar"));
EXPECT_EQ("foo: 1, bar: 2.0", SpdyStringPrintf("foo: %d, bar: %.1f", 1, 2.0));
}
+TEST(SpdyStrUtilsTest, SpdyStringAppendF) {
+ std::string output;
+
+ SpdyStringAppendF(&output, "%s", "");
+ EXPECT_TRUE(output.empty());
+
+ SpdyStringAppendF(&output, "%sbar", "foo");
+ EXPECT_EQ("foobar", output);
+
+ SpdyStringAppendF(&output, "%s%s", "foo", "bar");
+ EXPECT_EQ("foobarfoobar", output);
+
+ SpdyStringAppendF(&output, "foo: %d, bar: %.1f", 1, 2.0);
+ EXPECT_EQ("foobarfoobarfoo: 1, bar: 2.0", output);
+}
+
} // namespace
} // namespace test
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698