Issue 27780002: Add BUILD.gn files for weborigin/weborigin_unittests

Issue 27780002: Add BUILD.gn files for weborigin/weborigin_unittests (Closed)

Created:
7 years, 2 months ago by jamesr

Modified:
7 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add BUILD.gn files for weborigin/weborigin_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230157

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -1 line)			Patch
	M	tools/gn/secondary/BUILD.gn	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	A	tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jamesr

Seem pretty straightforward. Depends on https://codereview.chromium.org/25698002/

7 years, 2 months ago (2013-10-17 22:15:44 UTC) #1

brettw

lgtm https://codereview.chromium.org/27780002/diff/1/tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn File tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn (right): https://codereview.chromium.org/27780002/diff/1/tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn#newcode19 tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn:19: sources = [ Sources first, same below.

7 years, 2 months ago (2013-10-18 17:23:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/27780002/64001

7 years, 2 months ago (2013-10-22 09:20:09 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=211879

7 years, 2 months ago (2013-10-22 12:23:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/27780002/64001

7 years, 2 months ago (2013-10-22 16:45:02 UTC) #5

Message was sent while issue was closed.

Change committed as 230157

Expand Messages | Collapse Messages