Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html

Issue 2777983002: Convert Analyser tests to use new Audit. (Closed)
Patch Set: Remove console.logs Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html
index 17ea5b6205febb7428bee7cf2dc72f33e60bdce2..797b5058502283c38302d64734c368395b780b30 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fftsize-reset.html
@@ -5,7 +5,7 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
- <script src="../resources/audio-testing.js"></script>
+ <script src="../resources/audit.js"></script>
</head>
<body>
@@ -18,27 +18,27 @@
// Verify that setting the fftSize resets the memory for the FFT smoothing
// operation. Only a few of the possible variations are tested.
- audit.defineTask("128->1024", function (taskDone) {
- testFFTSize({
+ audit.define("128->1024", (task, should) => {
+ testFFTSize(should, {
initialFFTSize: 128,
finalFFTSize: 1024,
errorThreshold: {
relativeThreshold: 1.9095e-6
}
- }).then(taskDone);
+ }).then(() => task.done());
});
- audit.defineTask("512->256", function (taskDone) {
- testFFTSize({
+ audit.define("512->256", (task, should) => {
+ testFFTSize(should, {
initialFFTSize: 512,
finalFFTSize: 256,
errorThreshold: {
relativeThreshold: 1.8166e-6
}
- }).then(taskDone);
+ }).then(() => task.done());
});
- function testFFTSize(options) {
+ function testFFTSize(should, options) {
var {
initialFFTSize, finalFFTSize, errorThreshold
} = options;
@@ -106,28 +106,20 @@
var smoothing = 1 - testAnalyser.smoothingTimeConstant;
refFFT = refFFT.map(x => x * smoothing);
- var success = true;
-
// First a basic sanity check that the time domain signals are
// exactly the same for both analysers.
- success = Should("Time data", testSignal)
- .beCloseToArray(refSignal, 0) && success;
-
- success = Should("Linear FFT data after setting fftSize = " + testAnalyser.fftSize,
- testFFT)
- .beCloseToArray(refFFT, errorThreshold) && success;
+ should(testSignal, "Time data")
+ .beCloseToArray(refSignal, 0);
- Should("*** Changing fftSize from " + initialFFTSize + " to " + finalFFTSize, success)
- .summarize(
- "correctly reset the smoothing state",
- "did not correctly reset the smoothing state");
+ should(testFFT, "Linear FFT data after setting fftSize = " + testAnalyser.fftSize)
+ .beCloseToArray(refFFT, errorThreshold);
})
.then(context.resume.bind(context));
return context.startRendering();
}
- audit.runTasks();
+ audit.run();
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698