Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2777943005: [Bindings] Move and remove some private symbols from V8HiddenValue (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
index 9d394618e8f5b7ecd4e5e3cf2349167c631688aa..ce30a19034452b184fa565d642974a0c948fc513 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
@@ -6,7 +6,7 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ToV8.h"
-#include "bindings/core/v8/V8HiddenValue.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "modules/fetch/BytesConsumerForDataConsumerHandle.h"
#include "modules/fetch/Request.h"
#include "modules/fetch/Response.h"
@@ -97,9 +97,8 @@ FetchEvent::FetchEvent(ScriptState* scriptState,
DCHECK(event->IsObject());
// Sets a hidden value in order to teach V8 the dependency from
// the event to the request.
- V8HiddenValue::setHiddenValue(
- scriptState, event.As<v8::Object>(),
- V8HiddenValue::requestInFetchEvent(scriptState->isolate()), request);
+ V8PrivateProperty::getFetchEventRequest(scriptState->isolate())
+ .set(event.As<v8::Object>(), request);
haraken 2017/03/30 14:04:45 Ditto.
peria 2017/04/04 05:48:58 Acknowledged.
// From the same reason as above, setHiddenValue can return false.
// TODO(yhirano): Add an assertion that it returns true once the
// graceful shutdown mechanism is introduced.

Powered by Google App Engine
This is Rietveld 408576698