Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp

Issue 2777943005: [Bindings] Move and remove some private symbols from V8HiddenValue (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
index c30e71dd50de69f24fb1cffb275534458be8157d..0f7b94d1d8b3573cf3dd668c3b15c37896c5bb3a 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
@@ -25,9 +25,11 @@
#include "modules/indexeddb/IDBCursor.h"
+#include <limits>
+#include <memory>
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/ScriptState.h"
-#include "bindings/core/v8/V8HiddenValue.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/modules/v8/ToV8ForModules.h"
#include "bindings/modules/v8/V8BindingForModules.h"
#include "bindings/modules/v8/V8IDBRequest.h"
@@ -40,8 +42,6 @@
#include "modules/indexeddb/IDBTransaction.h"
#include "public/platform/modules/indexeddb/WebIDBDatabase.h"
#include "public/platform/modules/indexeddb/WebIDBKeyRange.h"
-#include <limits>
-#include <memory>
using blink::WebIDBCursor;
using blink::WebIDBDatabase;
@@ -93,9 +93,8 @@ v8::Local<v8::Object> IDBCursor::associateWithWrapper(
wrapper =
ScriptWrappable::associateWithWrapper(isolate, wrapperType, wrapper);
if (!wrapper.IsEmpty()) {
- V8HiddenValue::setHiddenValue(ScriptState::current(isolate), wrapper,
- V8HiddenValue::idbCursorRequest(isolate),
- ToV8(m_request.get(), wrapper, isolate));
+ V8PrivateProperty::getIDBCursorRequest(isolate).set(
+ wrapper, ToV8(m_request.get(), wrapper, isolate));
haraken 2017/03/30 14:04:45 Ditto.
peria 2017/04/04 05:48:58 Acknowledged.
}
return wrapper;
}

Powered by Google App Engine
This is Rietveld 408576698