Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Issue 2777923002: Disable two flaky tests in SitePerProcessTextInputManagerTest (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
diff --git a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
index cdc67f05ec2299aebca4e173c48874fd6e64ceff..6bf814893e619b2dc4323de2ce71a5f59cd8906a 100644
--- a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
+++ b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
@@ -871,16 +871,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
// This test makes sure browser correctly tracks focused editable element inside
// each RenderFrameHost.
-// Test is flaky on ChromeOS. crbug.com/705203
-#if defined(OS_CHROMEOS)
-#define MAYBE_TrackingFocusedElementForAllFrames \
- DISABLED_TrackingFocusedElementForAllFrames
-#else
-#define MAYBE_TrackingFocusedElementForAllFrames \
- TrackingFocusedElementForAllFrames
-#endif
+// Test is flaky. crbug.com/705203
IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
- MAYBE_TrackingFocusedElementForAllFrames) {
+ DISABLED_TrackingFocusedElementForAllFrames) {
CreateIframePage("a(a, b(a))");
std::vector<content::RenderFrameHost*> frames{
GetFrame(IndexVector{}), GetFrame(IndexVector{0}),
@@ -962,8 +955,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
// WebContents knows about the focused editable element. Then it asks the
// WebContents to clear focused element and verifies that there is no longer
// a focused editable element on the page.
+// Test is flaky. crbug.com/705203
IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
- ClearFocusedElementOnPage) {
+ DISABLED_ClearFocusedElementOnPage) {
CreateIframePage("a(a, b(a))");
std::vector<content::RenderFrameHost*> frames{
GetFrame(IndexVector{}), GetFrame(IndexVector{0}),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698