Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp

Issue 2777903005: Add WebThread in AudioDestination to support AudioWorkletThread (Closed)
Patch Set: Clean up after l-g-t-m Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp
diff --git a/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp b/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp
index 9351b4281d13b47fbf34e13dc8b9ae9643a9dabb..c0d1b77a78428d052029e58a9e657d2eb3789922 100644
--- a/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp
+++ b/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp
@@ -6,51 +6,57 @@
#include <memory>
#include <vector>
+#include "platform/CrossThreadFunctional.h"
+#include "platform/WebTaskRunner.h"
#include "platform/audio/AudioUtilities.h"
#include "platform/testing/TestingPlatformSupport.h"
+#include "platform/wtf/Functional.h"
#include "platform/wtf/PtrUtil.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebThread.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace blink {
namespace {
-// Check the basic contract of FIFO.
+// Check the basic contract of FIFO. This test only covers the single thread
+// scenario.
TEST(PushPullFIFOBasicTest, BasicTests) {
// This suppresses the multi-thread warning for GTest. Potently it increases
// the test execution time, but this specific test is very short and simple.
::testing::FLAGS_gtest_death_test_style = "threadsafe";
// FIFO length exceeding the maximum length allowed will cause crash.
- // i.e.) m_fifoLength <= kMaxFIFOLength
+ // i.e.) fifo_length_ <= kMaxFIFOLength
EXPECT_DEATH(new PushPullFIFO(2, PushPullFIFO::kMaxFIFOLength + 1), "");
std::unique_ptr<PushPullFIFO> test_fifo =
WTF::WrapUnique(new PushPullFIFO(2, 1024));
// The input bus length must be |AudioUtilities::kRenderQuantumFrames|.
- // i.e.) inputBus->length() == kRenderQuantumFrames
- RefPtr<AudioBus> input_bus_of129_frames =
+ // i.e.) input_bus->length() == kRenderQuantumFrames
+ RefPtr<AudioBus> input_bus_129_frames =
AudioBus::Create(2, AudioUtilities::kRenderQuantumFrames + 1);
- EXPECT_DEATH(test_fifo->Push(input_bus_of129_frames.Get()), "");
- RefPtr<AudioBus> input_bus_of127_frames =
+ EXPECT_DEATH(test_fifo->Push(input_bus_129_frames.Get()), "");
+ RefPtr<AudioBus> input_bus_127_frames =
AudioBus::Create(2, AudioUtilities::kRenderQuantumFrames - 1);
- EXPECT_DEATH(test_fifo->Push(input_bus_of127_frames.Get()), "");
+ EXPECT_DEATH(test_fifo->Push(input_bus_127_frames.Get()), "");
// Pull request frames cannot exceed the length of output bus.
- // i.e.) framesRequested <= outputBus->length()
- RefPtr<AudioBus> output_bus_of512_frames = AudioBus::Create(2, 512);
- EXPECT_DEATH(test_fifo->Pull(output_bus_of512_frames.Get(), 513), "");
+ // i.e.) frames_requested <= output_bus->length()
+ RefPtr<AudioBus> output_bus_512_frames = AudioBus::Create(2, 512);
+ EXPECT_DEATH(test_fifo->Pull(output_bus_512_frames.Get(), 513), "");
// Pull request frames cannot exceed the length of FIFO.
- // i.e.) framesRequested <= m_fifoLength
- RefPtr<AudioBus> output_bus_of1025_frames = AudioBus::Create(2, 1025);
- EXPECT_DEATH(test_fifo->Pull(output_bus_of1025_frames.Get(), 1025), "");
+ // i.e.) frames_requested <= fifo_length_
+ RefPtr<AudioBus> output_bus_1025_frames = AudioBus::Create(2, 1025);
+ EXPECT_DEATH(test_fifo->Pull(output_bus_1025_frames.Get(), 1025), "");
}
// Fills each AudioChannel in an AudioBus with a series of linearly increasing
-// values starting from |startingValue| and incrementing by 1. Then return value
-// will be |startingValue| + |bus_length|.
+// values starting from |starting_value| and incrementing by 1. Then return
+// value will be |starting_value| + |bus_length|.
size_t FillBusWithLinearRamp(AudioBus* target_bus, size_t starting_value) {
for (unsigned c = 0; c < target_bus->NumberOfChannels(); ++c) {
float* bus_channel = target_bus->Channel(c)->MutableData();
@@ -169,7 +175,8 @@ TEST_P(PushPullFIFOFeatureTest, FeatureTests) {
// Verify in-FIFO samples.
for (const auto& sample : expected_state.fifo_samples) {
- EXPECT_TRUE(VerifyBusValueAtIndex(fifo->Bus(), sample.index, sample.value));
+ EXPECT_TRUE(VerifyBusValueAtIndex(fifo->GetFIFOBusForTest(),
+ sample.index, sample.value));
}
// Verify samples from the most recent output bus.
« no previous file with comments | « third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698