Add WebThread in AudioDestination to support AudioWorkletThread

third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/audio/PushPullFIFO.h"
 
 #include <memory>
 #include <vector>
+#include "platform/CrossThreadFunctional.h"
+#include "platform/WebTaskRunner.h"
 #include "platform/audio/AudioUtilities.h"
 #include "platform/testing/TestingPlatformSupport.h"
+#include "platform/wtf/Functional.h"
 #include "platform/wtf/PtrUtil.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebThread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 namespace {
 

[o1ka, 2017/04/25 08:23:22]

Add a comment that tests here do not test multi-threading logic?

[hongchan, 2017/04/25 20:36:42]

Done.

 // Check the basic contract of FIFO.
 TEST(PushPullFIFOBasicTest, BasicTests) {
   // This suppresses the multi-thread warning for GTest. Potently it increases
   // the test execution time, but this specific test is very short and simple.
   ::testing::FLAGS_gtest_death_test_style = "threadsafe";
 
   // FIFO length exceeding the maximum length allowed will cause crash.
   // i.e.) m_fifoLength <= kMaxFIFOLength
   EXPECT_DEATH(new PushPullFIFO(2, PushPullFIFO::kMaxFIFOLength + 1), "");
 
   std::unique_ptr<PushPullFIFO> test_fifo =
       WTF::WrapUnique(new PushPullFIFO(2, 1024));
 
   // The input bus length must be |AudioUtilities::kRenderQuantumFrames|.
   // i.e.) inputBus->length() == kRenderQuantumFrames
-  RefPtr<AudioBus> input_bus_of129_frames =
+  RefPtr<AudioBus> input_bus_129_frames =
       AudioBus::Create(2, AudioUtilities::kRenderQuantumFrames + 1);
-  EXPECT_DEATH(test_fifo->Push(input_bus_of129_frames.Get()), "");
-  RefPtr<AudioBus> input_bus_of127_frames =
+  EXPECT_DEATH(test_fifo->Push(input_bus_129_frames.Get()), "");
+  RefPtr<AudioBus> input_bus_127_frames =
       AudioBus::Create(2, AudioUtilities::kRenderQuantumFrames - 1);
-  EXPECT_DEATH(test_fifo->Push(input_bus_of127_frames.Get()), "");
+  EXPECT_DEATH(test_fifo->Push(input_bus_127_frames.Get()), "");
 
   // Pull request frames cannot exceed the length of output bus.
   // i.e.) framesRequested <= outputBus->length()
-  RefPtr<AudioBus> output_bus_of512_frames = AudioBus::Create(2, 512);
-  EXPECT_DEATH(test_fifo->Pull(output_bus_of512_frames.Get(), 513), "");
+  RefPtr<AudioBus> output_bus_512_frames = AudioBus::Create(2, 512);
+  EXPECT_DEATH(test_fifo->Pull(output_bus_512_frames.Get(), 513), "");
 
   // Pull request frames cannot exceed the length of FIFO.
   // i.e.) framesRequested <= m_fifoLength
-  RefPtr<AudioBus> output_bus_of1025_frames = AudioBus::Create(2, 1025);
-  EXPECT_DEATH(test_fifo->Pull(output_bus_of1025_frames.Get(), 1025), "");
+  RefPtr<AudioBus> output_bus_1025_frames = AudioBus::Create(2, 1025);
+  EXPECT_DEATH(test_fifo->Pull(output_bus_1025_frames.Get(), 1025), "");
 }
 
 // Fills each AudioChannel in an AudioBus with a series of linearly increasing
 // values starting from |startingValue| and incrementing by 1. Then return value
 // will be |startingValue| + |bus_length|.
 size_t FillBusWithLinearRamp(AudioBus* target_bus, size_t starting_value) {
   for (unsigned c = 0; c < target_bus->NumberOfChannels(); ++c) {
     float* bus_channel = target_bus->Channel(c)->MutableData();
     for (size_t i = 0; i < target_bus->Channel(c)->length(); ++i) {
       bus_channel[i] = static_cast<float>(starting_value + i);
@@ skipping 103 matching lines @@
   const PushPullFIFOStateForTest actual_state = fifo->GetStateForTest();
 
   // Verify the read/write indexes.
   EXPECT_EQ(expected_state.index_read, actual_state.index_read);
   EXPECT_EQ(expected_state.index_write, actual_state.index_write);
   EXPECT_EQ(expected_state.overflow_count, actual_state.overflow_count);
   EXPECT_EQ(expected_state.underflow_count, actual_state.underflow_count);
 
   // Verify in-FIFO samples.
   for (const auto& sample : expected_state.fifo_samples) {
-    EXPECT_TRUE(VerifyBusValueAtIndex(fifo->Bus(), sample.index, sample.value));
+    EXPECT_TRUE(VerifyBusValueAtIndex(fifo->GetFIFOBusForTest(),
+                                      sample.index, sample.value));
   }
 
   // Verify samples from the most recent output bus.
   for (const auto& sample : expected_state.output_samples) {
     EXPECT_TRUE(
         VerifyBusValueAtIndex(output_bus.Get(), sample.index, sample.value));
   }
 }
 
 FIFOTestParam g_feature_test_params[] = {
@@ skipping 167 matching lines @@
       }},
      // - expectedIndexRead = 0, expectedIndexWrite = 0
      // - overflowCount = 0, underflowCount = 4
      // - FIFO samples (index, expectedValue) = (0, 0), (1023, 0)
      // - Output bus samples (index, expectedValue) = (0, 0), (143, 0)
      {0, 0, 0, 4, {{0, 0}, {1023, 0}}, {{0, 0}, {143, 0}}}}};
 
 INSTANTIATE_TEST_CASE_P(PushPullFIFOFeatureTest,
                         PushPullFIFOFeatureTest,
                         ::testing::ValuesIn(g_feature_test_params));
-
 }  // namespace
 
 }  // namespace blink