Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/test/chromedriver/util.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/util.cc
diff --git a/chrome/test/chromedriver/util.cc b/chrome/test/chromedriver/util.cc
index ebb69afb8d06fa79db8a9fb2e958d2a724b840d8..21294b4ef3c2b5fa6d5aec1e3c8fd08ab100d406 100644
--- a/chrome/test/chromedriver/util.cc
+++ b/chrome/test/chromedriver/util.cc
@@ -12,7 +12,6 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/format_macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/rand_util.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
@@ -404,11 +403,8 @@ Status UnzipSoleFile(const base::FilePath& unzip_dir,
Status NotifyCommandListenersBeforeCommand(Session* session,
const std::string& command_name) {
- for (ScopedVector<CommandListener>::const_iterator it =
- session->command_listeners.begin();
- it != session->command_listeners.end();
- ++it) {
- Status status = (*it)->BeforeCommand(command_name);
+ for (const auto& listener : session->command_listeners) {
+ Status status = listener->BeforeCommand(command_name);
if (status.IsError()) {
// Do not continue if an error is encountered. Mark session for deletion,
// quit Chrome if necessary, and return a detailed error.
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698