Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10555)

Unified Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging_unittest.cc
diff --git a/chrome/test/chromedriver/logging_unittest.cc b/chrome/test/chromedriver/logging_unittest.cc
index 907e885f6fcd65913c43e72a54e6aa59320cb827..b3b0c907bb84160cbadf31aa08c26d6acaa1bfe0 100644
--- a/chrome/test/chromedriver/logging_unittest.cc
+++ b/chrome/test/chromedriver/logging_unittest.cc
@@ -4,6 +4,9 @@
#include <stddef.h>
+#include <memory>
+#include <vector>
+
#include "base/format_macros.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
@@ -109,9 +112,9 @@ TEST(Logging, CreatePerformanceLog) {
capabilities.logging_prefs["performance"] = Log::kInfo;
capabilities.logging_prefs["browser"] = Log::kInfo;
- ScopedVector<DevToolsEventListener> devtools_listeners;
- ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
+ std::vector<std::unique_ptr<DevToolsEventListener>> devtools_listeners;
+ std::vector<std::unique_ptr<WebDriverLog>> logs;
+ std::vector<std::unique_ptr<CommandListener>> command_listeners;
Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
ASSERT_TRUE(status.IsOk());
@@ -127,9 +130,9 @@ TEST(Logging, IgnoreUnknownLogType) {
Session session("test");
capabilities.logging_prefs["gaga"] = Log::kInfo;
- ScopedVector<DevToolsEventListener> devtools_listeners;
- ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
+ std::vector<std::unique_ptr<DevToolsEventListener>> devtools_listeners;
+ std::vector<std::unique_ptr<WebDriverLog>> logs;
+ std::vector<std::unique_ptr<CommandListener>> command_listeners;
Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
EXPECT_TRUE(status.IsOk());
@@ -143,9 +146,9 @@ TEST(Logging, DefaultLogs) {
Capabilities capabilities;
Session session("test");
- ScopedVector<DevToolsEventListener> devtools_listeners;
- ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
+ std::vector<std::unique_ptr<DevToolsEventListener>> devtools_listeners;
+ std::vector<std::unique_ptr<WebDriverLog>> logs;
+ std::vector<std::unique_ptr<CommandListener>> command_listeners;
Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
EXPECT_TRUE(status.IsOk());
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698