Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/test/chromedriver/logging.h

Issue 2777883003: Remove ScopedVector from chrome/test/chromedriver/ (Closed)
Patch Set: address nit from stgao@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging.h
diff --git a/chrome/test/chromedriver/logging.h b/chrome/test/chromedriver/logging.h
index 6518f83b406fc2cd4717599de2e99ab6d29e5261..262fe1a1bd9281c4086a01a1ebb0f94a79615528 100644
--- a/chrome/test/chromedriver/logging.h
+++ b/chrome/test/chromedriver/logging.h
@@ -8,9 +8,9 @@
#include <deque>
#include <memory>
#include <string>
+#include <vector>
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/log.h"
@@ -83,10 +83,11 @@ bool InitLogging();
// Creates |Log|s, |DevToolsEventListener|s, and |CommandListener|s based on
// logging preferences.
-Status CreateLogs(const Capabilities& capabilities,
- const Session* session,
- ScopedVector<WebDriverLog>* out_logs,
- ScopedVector<DevToolsEventListener>* out_devtools_listeners,
- ScopedVector<CommandListener>* out_command_listeners);
+Status CreateLogs(
+ const Capabilities& capabilities,
+ const Session* session,
+ std::vector<std::unique_ptr<WebDriverLog>>* out_logs,
+ std::vector<std::unique_ptr<DevToolsEventListener>>* out_devtools_listeners,
+ std::vector<std::unique_ptr<CommandListener>>* out_command_listeners);
#endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698